diff mbox

[v2,12/13] Revert "block: Forbid I/O throttling on nodes with multiple parents for 2.6"

Message ID 1461346962-4676-13-git-send-email-kwolf@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Kevin Wolf April 22, 2016, 5:42 p.m. UTC 
This reverts commit 76b223200ef4fb09dd87f0e213159795eb68e7a5.

Now that I/O throttling is fully done on the BlockBackend level, there
is no reason any more to block I/O throttling for nodes with multiple
parents as the parents don't influence each other any more.

Conflicts:
	block.c

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block.c    | 6 ------
 blockdev.c | 7 -------
 2 files changed, 13 deletions(-)

Comments

Alberto Garcia May 9, 2016, 12:31 p.m. UTC | #1 
On Fri 22 Apr 2016 07:42:41 PM CEST, Kevin Wolf wrote:
> This reverts commit 76b223200ef4fb09dd87f0e213159795eb68e7a5.
>
> Now that I/O throttling is fully done on the BlockBackend level, there
> is no reason any more to block I/O throttling for nodes with multiple
> parents as the parents don't influence each other any more.
>
> Conflicts:
> 	block.c
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Reviewed-by: Alberto Garcia <berto@igalia.com>

Berto
diff mbox

Patch

diff --git a/block.c b/block.c
index 32527dc..d8c6e98 100644
--- a/block.c
+++ b/block.c
@@ -1524,12 +1524,6 @@  static int bdrv_open_inherit(BlockDriverState **pbs, const char *filename,
             return -ENODEV;
         }
 
-        if (blk_get_public(bs->blk)->throttle_state) {
-            error_setg(errp, "Cannot reference an existing block device for "
-                       "which I/O throttling is enabled");
-            return -EINVAL;
-        }
-
         bdrv_ref(bs);
         *pbs = bs;
         return 0;
diff --git a/blockdev.c b/blockdev.c
index 337747e..7441212 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2652,13 +2652,6 @@  void qmp_block_set_io_throttle(const char *device, int64_t bps, int64_t bps_rd,
         goto out;
     }
 
-    /* The BlockBackend must be the only parent */
-    assert(QLIST_FIRST(&bs->parents));
-    if (QLIST_NEXT(QLIST_FIRST(&bs->parents), next_parent)) {
-        error_setg(errp, "Cannot throttle device with multiple parents");
-        goto out;
-    }
-
     throttle_config_init(&cfg);
     cfg.buckets[THROTTLE_BPS_TOTAL].avg = bps;
     cfg.buckets[THROTTLE_BPS_READ].avg  = bps_rd;