From patchwork Wed Apr 27 11:50:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Matias_Bj=C3=B8rling?= X-Patchwork-Id: 8955961 Return-Path: X-Original-To: patchwork-linux-block@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 9A5279F1D3 for ; Wed, 27 Apr 2016 11:51:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9F732201C7 for ; Wed, 27 Apr 2016 11:51:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DF2D201BB for ; Wed, 27 Apr 2016 11:51:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753130AbcD0LvP (ORCPT ); Wed, 27 Apr 2016 07:51:15 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:36333 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752663AbcD0LvA (ORCPT ); Wed, 27 Apr 2016 07:51:00 -0400 Received: by mail-wm0-f51.google.com with SMTP id n129so23578141wmn.1 for ; Wed, 27 Apr 2016 04:50:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bjorling.me; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wWM5IAqub/3z1J4FvxA/uiX8qg93tvrrvh6/5sl/1xA=; b=Kv/MTC44WI6MpyOiza2aHZEB1pmyiwQzizUnPilxbLeHOHeZKbY0gbniL+aIDKkuDK MrkG6cQRQNbOOim/ZaMmXozD2Mcyg6m9FEC10x0ltsu7rGmwuuAOaD2sqolF8HH3hW02 wiEV1m8kPYUxi6LwcWKrvpNrtVc5/pQUVD2FM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wWM5IAqub/3z1J4FvxA/uiX8qg93tvrrvh6/5sl/1xA=; b=fbggNT5daVNj/59FcZ1SDxas+FBHyfb7IOHdnwA4UzOVRyPIPEV0q0oy94dIBm244V BbCAZmKzvM5caYxoc3xuUTjm4ryXGmn0JNmaW359mNUvUFBpP4f/esXwy80w+1X2maIY IbWmNlsFY3vQ9WT5IgaLsuEAG4hWnp/vvXDhSY8V4RFGfk1cCiL1vK+wuSkWLsLw7HHM UmdL7/kqUssiOLsirYLFY8zUa+9zKXiyqWUAw8kTQu6+iIchuu+IRUf7VeT0+QcRLcte 8IL5fa240uE1yJ13r+b7iDbP03olRLvKED7m5hXA+ZLLm22q09jgqvVt/5lHyTKW5aXt 7wUw== X-Gm-Message-State: AOPr4FUiWl6U+AOTZhr/A36H4FFsCL2vILD3lCDpnH5O7Y+w2T0lE0hNcwprHX5f2o+Vcw== X-Received: by 10.194.175.70 with SMTP id by6mr8630865wjc.19.1461757858696; Wed, 27 Apr 2016 04:50:58 -0700 (PDT) Received: from Macroninja.cnexlabs.com (6164211-cl69.boa.fiberby.dk. [193.106.164.211]) by smtp.gmail.com with ESMTPSA id ju3sm3684846wjb.11.2016.04.27.04.50.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 27 Apr 2016 04:50:58 -0700 (PDT) From: =?UTF-8?q?Matias=20Bj=C3=B8rling?= To: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: =?UTF-8?q?Matias=20Bj=C3=B8rling?= Subject: [PATCH 2/2] lightnvm: refactor set_bb_tbl for accepting ppa list Date: Wed, 27 Apr 2016 13:50:14 +0200 Message-Id: <1461757814-7086-2-git-send-email-m@bjorling.me> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1461757814-7086-1-git-send-email-m@bjorling.me> References: <1461757814-7086-1-git-send-email-m@bjorling.me> MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The set_bb_tbl takes struct nvm_rq and only uses its ppa_list and nr_pages internally. Instead, make these two variables explicit. This allows a user to call it without initializing a struct nvm_rq first. Signed-off-by: Matias Bjørling --- drivers/lightnvm/sysblk.c | 2 +- drivers/nvme/host/lightnvm.c | 8 ++++---- include/linux/lightnvm.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/lightnvm/sysblk.c b/drivers/lightnvm/sysblk.c index 7fce588..21c5568 100644 --- a/drivers/lightnvm/sysblk.c +++ b/drivers/lightnvm/sysblk.c @@ -229,7 +229,7 @@ static int nvm_set_bb_tbl(struct nvm_dev *dev, struct sysblk_scan *s, int type) nvm_set_rqd_ppalist(dev, &rqd, s->ppas, s->nr_ppas); nvm_generic_to_addr_mode(dev, &rqd); - ret = dev->ops->set_bb_tbl(dev, &rqd, type); + ret = dev->ops->set_bb_tbl(dev, &rqd.ppa_addr, rqd.nr_pages, type); nvm_free_rqd_ppalist(dev, &rqd); if (ret) { pr_err("nvm: sysblk failed bb mark\n"); diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c index d289980..011d2e7 100644 --- a/drivers/nvme/host/lightnvm.c +++ b/drivers/nvme/host/lightnvm.c @@ -443,8 +443,8 @@ out: return ret; } -static int nvme_nvm_set_bb_tbl(struct nvm_dev *nvmdev, struct nvm_rq *rqd, - int type) +static int nvme_nvm_set_bb_tbl(struct nvm_dev *nvmdev, struct ppa_addr *ppas, + int nr_ppas, int type) { struct nvme_ns *ns = nvmdev->q->queuedata; struct nvme_nvm_command c = {}; @@ -452,8 +452,8 @@ static int nvme_nvm_set_bb_tbl(struct nvm_dev *nvmdev, struct nvm_rq *rqd, c.set_bb.opcode = nvme_nvm_admin_set_bb_tbl; c.set_bb.nsid = cpu_to_le32(ns->ns_id); - c.set_bb.spba = cpu_to_le64(rqd->ppa_addr.ppa); - c.set_bb.nlb = cpu_to_le16(rqd->nr_pages - 1); + c.set_bb.spba = cpu_to_le64(ppas->ppa); + c.set_bb.nlb = cpu_to_le16(nr_ppas - 1); c.set_bb.value = type; ret = nvme_submit_sync_cmd(ns->ctrl->admin_q, (struct nvme_command *)&c, diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h index 5eabdba..80ea51f 100644 --- a/include/linux/lightnvm.h +++ b/include/linux/lightnvm.h @@ -48,7 +48,7 @@ typedef int (nvm_get_l2p_tbl_fn)(struct nvm_dev *, u64, u32, nvm_l2p_update_fn *, void *); typedef int (nvm_op_bb_tbl_fn)(struct nvm_dev *, struct ppa_addr, nvm_bb_update_fn *, void *); -typedef int (nvm_op_set_bb_fn)(struct nvm_dev *, struct nvm_rq *, int); +typedef int (nvm_op_set_bb_fn)(struct nvm_dev *, struct ppa_addr *, int, int); typedef int (nvm_submit_io_fn)(struct nvm_dev *, struct nvm_rq *); typedef int (nvm_erase_blk_fn)(struct nvm_dev *, struct nvm_rq *); typedef void *(nvm_create_dma_pool_fn)(struct nvm_dev *, char *);