diff mbox

[i-g-t,1/3] igt_kms: Fix use after free in kmstest_get_pipe_from_crtc_id

Message ID 1461769956-33188-1-git-send-email-tvrtko.ursulin@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Tvrtko Ursulin April 27, 2016, 3:12 p.m. UTC 
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 lib/igt_kms.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Tvrtko Ursulin April 28, 2016, 9:14 a.m. UTC | #1 
On 27/04/16 16:12, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>   lib/igt_kms.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index ef24a4965567..7557bdc20fa4 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -402,10 +402,10 @@ int kmstest_get_pipe_from_crtc_id(int fd, int crtc_id)
>   			break;
>   	}
>
> -	drmModeFreeResources(res);
> -
>   	igt_assert(i < res->count_crtcs);
>
> +	drmModeFreeResources(res);
> +
>   	return i;
>   }
>
>

I've pushed this since it is obvious.

Regards,

Tvrtko
diff mbox

Patch

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index ef24a4965567..7557bdc20fa4 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -402,10 +402,10 @@  int kmstest_get_pipe_from_crtc_id(int fd, int crtc_id)
 			break;
 	}
 
-	drmModeFreeResources(res);
-
 	igt_assert(i < res->count_crtcs);
 
+	drmModeFreeResources(res);
+
 	return i;
 }