| Message ID | 1308603674-19264-1-git-send-email-w.sang@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fef95faeae9fa5f605fbad8693e2d6e2171f5ad4 |
| Headers | show |
On Mon, 20 Jun 2011 23:01:12 +0200, Wolfram Sang wrote: > A few new i2c-drivers came into the kernel which clear the clientdata-pointer > on exit or error. This is obsolete meanwhile, the core will do it. > > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: Bo Shen <voice.shen@atmel.com> > Cc: Axel Lin <axel.lin@gmail.com> Acked-by: Jean Delvare <khali@linux-fr.org> > --- > > This is more a cleanup than a bugfix. Still, would be happy to have this > obsolete programming style largely removed in 3.0 if possible. > > drivers/input/keyboard/qt1070.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/keyboard/qt1070.c b/drivers/input/keyboard/qt1070.c > index ca7b891..b21bf5b 100644 > --- a/drivers/input/keyboard/qt1070.c > +++ b/drivers/input/keyboard/qt1070.c > @@ -239,8 +239,6 @@ static int __devexit qt1070_remove(struct i2c_client *client) > input_unregister_device(data->input); > kfree(data); > > - i2c_set_clientdata(client, NULL); > - > return 0; > } >
On Tue, Jun 21, 2011 at 10:55:32AM +0200, Jean Delvare wrote: > On Mon, 20 Jun 2011 23:01:12 +0200, Wolfram Sang wrote: > > A few new i2c-drivers came into the kernel which clear the clientdata-pointer > > on exit or error. This is obsolete meanwhile, the core will do it. > > > > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > Cc: Bo Shen <voice.shen@atmel.com> > > Cc: Axel Lin <axel.lin@gmail.com> > > Acked-by: Jean Delvare <khali@linux-fr.org> > Applied, thanks Wolfram.
diff --git a/drivers/input/keyboard/qt1070.c b/drivers/input/keyboard/qt1070.c index ca7b891..b21bf5b 100644 --- a/drivers/input/keyboard/qt1070.c +++ b/drivers/input/keyboard/qt1070.c @@ -239,8 +239,6 @@ static int __devexit qt1070_remove(struct i2c_client *client) input_unregister_device(data->input); kfree(data); - i2c_set_clientdata(client, NULL); - return 0; }
A few new i2c-drivers came into the kernel which clear the clientdata-pointer on exit or error. This is obsolete meanwhile, the core will do it. Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Bo Shen <voice.shen@atmel.com> Cc: Axel Lin <axel.lin@gmail.com> --- This is more a cleanup than a bugfix. Still, would be happy to have this obsolete programming style largely removed in 3.0 if possible. drivers/input/keyboard/qt1070.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)