kmod: compiling with old sed version (!ERE support)
diff mbox

Message ID 1462199904-797-1-git-send-email-hector.oron@gmail.com
State Accepted
Headers show

Commit Message

Hector Oron May 2, 2016, 2:38 p.m. UTC
From: Héctor Orón Martínez <hector.oron@gmail.com>

  Makefile.am uses `sed -E', which it is found on BSD sed; however a
  replacement on GNU sed would be `sed -r'. Both intend to use extended
  regular expressions (ERE). However I have a system that does not support
  those, in benefit for portability could you consider replacing ERE by BRE.

Signed-off-by: Héctor Orón Martínez <hector.oron@gmail.com>
---
 Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lucas De Marchi May 21, 2016, 6:09 p.m. UTC | #1
On Mon, May 2, 2016 at 11:38 AM,  <hector.oron@gmail.com> wrote:
> From: Héctor Orón Martínez <hector.oron@gmail.com>
>
>   Makefile.am uses `sed -E', which it is found on BSD sed; however a
>   replacement on GNU sed would be `sed -r'. Both intend to use extended
>   regular expressions (ERE). However I have a system that does not support
>   those, in benefit for portability could you consider replacing ERE by BRE.
>
> Signed-off-by: Héctor Orón Martínez <hector.oron@gmail.com>
> ---

Applied, thanks.

Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-modules" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/Makefile.am b/Makefile.am
index 2d9f2cf..8813475 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -107,7 +107,7 @@  install-exec-hook:
 	if test "$(libdir)" != "$(rootlibdir)"; then \
 		$(MKDIR_P) $(DESTDIR)$(rootlibdir) && \
 		so_img_name=$$(readlink $(DESTDIR)$(libdir)/libkmod.so) && \
-		so_img_rel_target_prefix=$$(echo $(libdir) | sed -E 's,(^/|)[^/][^/]*,..,g') && \
+		so_img_rel_target_prefix=$$(echo $(libdir) | sed 's,\(^/\|\)[^/][^/]*,..,g') && \
 		ln -sf $$so_img_rel_target_prefix$(rootlibdir)/$$so_img_name $(DESTDIR)$(libdir)/libkmod.so && \
 		mv $(DESTDIR)$(libdir)/libkmod.so.* $(DESTDIR)$(rootlibdir); \
 	fi