| Message ID | 1462371194-5809-4-git-send-email-david.wu@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
David, On Wed, May 4, 2016 at 7:13 AM, David Wu <david.wu@rock-chips.com> wrote: > Call rk3x_i2c_setup() before rk3x_i2c_start() > and the last thing in setup was to clean the IPD, > so no reason to do it at the beginning of start. > > Signed-off-by: David Wu <david.wu@rock-chips.com> > --- > Change in v7: > - none > > drivers/i2c/busses/i2c-rk3x.c | 1 - > 1 file changed, 1 deletion(-) Looks great. Thanks for splitting this out from other patches--makes it much more obvious what's happening! :) IMHO this can be applied any time independent of any earlier patches. Reviewed-by: Douglas Anderson <dianders@chromium.org>
diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c index 1e2677a..9eeb4e5 100644 --- a/drivers/i2c/busses/i2c-rk3x.c +++ b/drivers/i2c/busses/i2c-rk3x.c @@ -174,7 +174,6 @@ static void rk3x_i2c_start(struct rk3x_i2c *i2c) { u32 val; - rk3x_i2c_clean_ipd(i2c); i2c_writel(i2c, REG_INT_START, REG_IEN); /* enable adapter with correct mode, send START condition */
Call rk3x_i2c_setup() before rk3x_i2c_start() and the last thing in setup was to clean the IPD, so no reason to do it at the beginning of start. Signed-off-by: David Wu <david.wu@rock-chips.com> --- Change in v7: - none drivers/i2c/busses/i2c-rk3x.c | 1 - 1 file changed, 1 deletion(-)