diff mbox

[OMAPZOOM,1/3] ISP: Remove hardcoding of CCDC input offset.

Message ID 200902261639.45623.dcurran@ti.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Dominic Curran Feb. 26, 2009, 10:39 p.m. UTC 
From: Dominic Curran <dcurran@ti.com>
Subject: [OMAPZOOM][PATCH 1/3] ISP: Remove hardcoding of CCDC input offset.

The Sony IMX046 patch set introduced a bug when setting CCDC input offsets.
The Sony patch set the horz & vert offsets to 0.
This worked from the Sony IMX046, but broke settings for other sensors like 
MT9P012 & OV3640.
The reason is that all three sensors send their data with different component 
orders.

The effect was to mess up colours in previewer module for MT9P012 & OV3640.
This patch reverts that bug.

The other patches in this set will provide a better way of setting these offsets, 
thus allowing easy setup for any type kind of incoming componenet order.

Signed-off-by: Dominic Curran <dcurran@ti.com>
---
 drivers/media/video/isp/ispccdc.c |    2 --
 1 file changed, 2 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

Index: omapzoom04/drivers/media/video/isp/ispccdc.c
===================================================================
--- omapzoom04.orig/drivers/media/video/isp/ispccdc.c
+++ omapzoom04/drivers/media/video/isp/ispccdc.c
@@ -1265,8 +1265,6 @@  int ispccdc_config_size(u32 input_w, u32
 	}
 
 	if (ispccdc_obj.ccdc_outfmt == CCDC_OTHERS_VP) {
-		ispccdc_obj.ccdcin_woffset = 0;
-		ispccdc_obj.ccdcin_hoffset = 0;
 		omap_writel((ispccdc_obj.ccdcin_woffset <<
 					ISPCCDC_FMT_HORZ_FMTSPH_SHIFT) |
 					(ispccdc_obj.ccdcin_w <<