diff mbox

[PATCH-for-4.7,1/2] xendriverdomain: use POSIX sh and not bash

Message ID 1463066970-39711-1-git-send-email-cardoe@cardoe.com (mailing list archive)
State New, archived
Headers show

Commit Message

Douglas Goldstein May 12, 2016, 3:29 p.m. UTC
The script doesn't use any bash-isms and works fine with BusyBox's ash.

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
---
 tools/hotplug/Linux/init.d/xendriverdomain.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wei Liu May 12, 2016, 3:56 p.m. UTC | #1
On Thu, May 12, 2016 at 10:29:29AM -0500, Doug Goldstein wrote:
> The script doesn't use any bash-isms and works fine with BusyBox's ash.
> 
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>
Release-acked-by: Wei Liu <wei.liu2@citrix.com>

> ---
>  tools/hotplug/Linux/init.d/xendriverdomain.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/hotplug/Linux/init.d/xendriverdomain.in b/tools/hotplug/Linux/init.d/xendriverdomain.in
> index 5fd4e9a..8d4592a 100644
> --- a/tools/hotplug/Linux/init.d/xendriverdomain.in
> +++ b/tools/hotplug/Linux/init.d/xendriverdomain.in
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/bin/sh
>  #
>  # xendriverdomain    Script to start services needed in a Xen driver domain
>  #
> -- 
> 2.7.4 (Apple Git-66)
>
Wei Liu May 12, 2016, 5:02 p.m. UTC | #2
On Thu, May 12, 2016 at 04:56:30PM +0100, Wei Liu wrote:
> On Thu, May 12, 2016 at 10:29:29AM -0500, Doug Goldstein wrote:
> > The script doesn't use any bash-isms and works fine with BusyBox's ash.
> > 
> > Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>
> Release-acked-by: Wei Liu <wei.liu2@citrix.com>
> 

Pushed.
diff mbox

Patch

diff --git a/tools/hotplug/Linux/init.d/xendriverdomain.in b/tools/hotplug/Linux/init.d/xendriverdomain.in
index 5fd4e9a..8d4592a 100644
--- a/tools/hotplug/Linux/init.d/xendriverdomain.in
+++ b/tools/hotplug/Linux/init.d/xendriverdomain.in
@@ -1,4 +1,4 @@ 
-#!/bin/bash
+#!/bin/sh
 #
 # xendriverdomain    Script to start services needed in a Xen driver domain
 #