diff mbox

[radeon] Change the default to PCI on PowerPC

Message ID 1463120999-8249-1-git-send-email-mathieu.malaterre@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Mathieu Malaterre May 13, 2016, 6:29 a.m. UTC
AGP mode is unstable on PowerPC

Signed-off-by: Mathieu Malaterre <mathieu.malaterre@gmail.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
---
 drivers/gpu/drm/radeon/radeon_drv.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Mathieu Malaterre June 9, 2016, 6:45 a.m. UTC | #1
ping ?

2016-05-13 8:29 GMT+02:00 Mathieu Malaterre <mathieu.malaterre@gmail.com>:
> AGP mode is unstable on PowerPC
>
> Signed-off-by: Mathieu Malaterre <mathieu.malaterre@gmail.com>
> Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
>  drivers/gpu/drm/radeon/radeon_drv.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index ccd4ad4..402cf85 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -170,7 +170,12 @@ int radeon_no_wb;
>  int radeon_modeset = -1;
>  int radeon_dynclks = -1;
>  int radeon_r4xx_atom = 0;
> +#ifdef __powerpc__
> +/* Default to PCI on PowerPC (fdo #95017) */
> +int radeon_agpmode = -1;
> +#else
>  int radeon_agpmode = 0;
> +#endif
>  int radeon_vram_limit = 0;
>  int radeon_gart_size = -1; /* auto */
>  int radeon_benchmarking = 0;
> --
> 2.1.4
>
Mathieu Malaterre Sept. 19, 2016, 12:28 p.m. UTC | #2
Is there a chance this patch could be considered for inclusion ? It
has been reviewed and it is well known that PCI generally work best by
default. It will solve a long standing issue when user experience
Debian on a Powermac and quickly get a non-working (freezing) X
session.

Thanks again for consideration.

2016-05-13 8:29 GMT+02:00 Mathieu Malaterre <mathieu.malaterre@gmail.com>:
> AGP mode is unstable on PowerPC
>
> Signed-off-by: Mathieu Malaterre <mathieu.malaterre@gmail.com>
> Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
>  drivers/gpu/drm/radeon/radeon_drv.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index ccd4ad4..402cf85 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -170,7 +170,12 @@ int radeon_no_wb;
>  int radeon_modeset = -1;
>  int radeon_dynclks = -1;
>  int radeon_r4xx_atom = 0;
> +#ifdef __powerpc__
> +/* Default to PCI on PowerPC (fdo #95017) */
> +int radeon_agpmode = -1;
> +#else
>  int radeon_agpmode = 0;
> +#endif
>  int radeon_vram_limit = 0;
>  int radeon_gart_size = -1; /* auto */
>  int radeon_benchmarking = 0;
> --
> 2.1.4
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
index ccd4ad4..402cf85 100644
--- a/drivers/gpu/drm/radeon/radeon_drv.c
+++ b/drivers/gpu/drm/radeon/radeon_drv.c
@@ -170,7 +170,12 @@  int radeon_no_wb;
 int radeon_modeset = -1;
 int radeon_dynclks = -1;
 int radeon_r4xx_atom = 0;
+#ifdef __powerpc__
+/* Default to PCI on PowerPC (fdo #95017) */
+int radeon_agpmode = -1;
+#else
 int radeon_agpmode = 0;
+#endif
 int radeon_vram_limit = 0;
 int radeon_gart_size = -1; /* auto */
 int radeon_benchmarking = 0;