diff mbox

spi: fix __spi_pump_messages deadlock

Message ID 1463131892-5392-1-git-send-email-thomas.perrot@tupi.fr (mailing list archive)
State New, archived
Headers show

Commit Message

Thomas Perrot May 13, 2016, 9:31 a.m. UTC
Signed-off-by: Thomas Perrot <thomas.perrot@tupi.fr>
---
 drivers/spi/spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown May 13, 2016, 10:33 a.m. UTC | #1
On Fri, May 13, 2016 at 11:31:32AM +0200, Thomas Perrot wrote:
> Signed-off-by: Thomas Perrot <thomas.perrot@tupi.fr>

This really isn't adequate, you need to provide a changelog.  Simply
saying that there is a deadlock is not enough, you need to say what the
deadlock is and why your change fixes it.
diff mbox

Patch

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 0239b45..785080a 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -1192,7 +1192,7 @@  static void __spi_pump_messages(struct spi_master *master, bool in_kthread,
 	}
 
 out:
-	if (!bus_locked)
+	if (bus_locked)
 		mutex_unlock(&master->bus_lock_mutex);
 
 	/* Prod the scheduler in case transfer_one() was busy waiting */