[1/3] btrfs-progs: fix make install failure
diff mbox

Message ID 1463634794-591-2-git-send-email-anand.jain@oracle.com
State New
Headers show

Commit Message

Anand Jain May 19, 2016, 5:13 a.m. UTC
/usr/bin/install -c -m644 -d 64-btrfs-dm.rules /usr/lib/udev/rules.d
/usr/bin/install: cannot create directory ‘64-btrfs-dm.rules’: File exists
Makefile:400: recipe for target 'install' failed
make: *** [install] Error 1

fixes: btrfs-progs: udev: add rules for dm devices

Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
 Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Sterba May 19, 2016, noon UTC | #1
On Thu, May 19, 2016 at 01:13:12PM +0800, Anand Jain wrote:
> /usr/bin/install -c -m644 -d 64-btrfs-dm.rules /usr/lib/udev/rules.d
> /usr/bin/install: cannot create directory ‘64-btrfs-dm.rules’: File exists
> Makefile:400: recipe for target 'install' failed
> make: *** [install] Error 1
> 
> fixes: btrfs-progs: udev: add rules for dm devices

>  ifneq ($(udevdir),)
> -	$(INSTALL) -m644 -d $(udev_rules) $(DESTDIR)$(udevruledir)
> +	$(INSTALL) -m644 $(udev_rules) $(DESTDIR)$(udevruledir)
>  endif

We have to conditionally create the directory, so extra -d on the
udevrule or -D is needed. Looking at the patch we have in openSUSE, it
does the former. I'll update the patch.

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/Makefile.in b/Makefile.in
index 47e73c9fbc4e..238dd59badaf 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -408,7 +408,7 @@  install: $(libs) $(progs_install) $(INSTALLDIRS)
 	$(INSTALL) -m755 -d $(DESTDIR)$(incdir)
 	$(INSTALL) -m644 $(headers) $(DESTDIR)$(incdir)
 ifneq ($(udevdir),)
-	$(INSTALL) -m644 -d $(udev_rules) $(DESTDIR)$(udevruledir)
+	$(INSTALL) -m644 $(udev_rules) $(DESTDIR)$(udevruledir)
 endif
 
 install-static: $(progs_static) $(INSTALLDIRS)