security: tomoyo: simplify the gc kthread creation
diff mbox

Message ID 1463719073-1346-1-git-send-email-mikedanese@google.com
State New
Headers show

Commit Message

Mike Danese May 20, 2016, 4:37 a.m. UTC
The code is doing the equivalent of the kthread_run macro.

Signed-off-by: Mike Danese <mikedanese@google.com>
---
 security/tomoyo/gc.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

Comments

Tetsuo Handa May 20, 2016, 11:59 a.m. UTC | #1
Mike Danese wrote:
> The code is doing the equivalent of the kthread_run macro.
> 
> Signed-off-by: Mike Danese <mikedanese@google.com>

Acked-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>

> ---
>  security/tomoyo/gc.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/security/tomoyo/gc.c b/security/tomoyo/gc.c
> index 986a6a7..540bc29 100644
> --- a/security/tomoyo/gc.c
> +++ b/security/tomoyo/gc.c
> @@ -645,11 +645,6 @@ void tomoyo_notify_gc(struct tomoyo_io_buffer *head, const bool is_register)
>  		}
>  	}
>  	spin_unlock(&tomoyo_io_buffer_list_lock);
> -	if (is_write) {
> -		struct task_struct *task = kthread_create(tomoyo_gc_thread,
> -							  NULL,
> -							  "GC for TOMOYO");
> -		if (!IS_ERR(task))
> -			wake_up_process(task);
> -	}
> +	if (is_write)
> +		kthread_run(tomoyo_gc_thread, NULL, "GC for TOMOYO");
>  }
> -- 
> 2.5.0
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
James Morris June 6, 2016, 9:53 a.m. UTC | #2
On Fri, 20 May 2016, Tetsuo Handa wrote:

> Mike Danese wrote:
> > The code is doing the equivalent of the kthread_run macro.
> > 
> > Signed-off-by: Mike Danese <mikedanese@google.com>
> 
> Acked-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next

Patch
diff mbox

diff --git a/security/tomoyo/gc.c b/security/tomoyo/gc.c
index 986a6a7..540bc29 100644
--- a/security/tomoyo/gc.c
+++ b/security/tomoyo/gc.c
@@ -645,11 +645,6 @@  void tomoyo_notify_gc(struct tomoyo_io_buffer *head, const bool is_register)
 		}
 	}
 	spin_unlock(&tomoyo_io_buffer_list_lock);
-	if (is_write) {
-		struct task_struct *task = kthread_create(tomoyo_gc_thread,
-							  NULL,
-							  "GC for TOMOYO");
-		if (!IS_ERR(task))
-			wake_up_process(task);
-	}
+	if (is_write)
+		kthread_run(tomoyo_gc_thread, NULL, "GC for TOMOYO");
 }