diff mbox

[14/25] ARM: pm: plat-s3c24xx: cleanup s3c_cpu_save

Message ID E1QZpLW-0005mn-4R@rmk-PC.arm.linux.org.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Russell King - ARM Linux June 23, 2011, 7:13 p.m. UTC
s3c_cpu_save does not need to save any registers with the new
cpu_suspend calling convention.  Remove these redundant instructions.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
 arch/arm/plat-s3c24xx/sleep.S |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

Comments

Kim Kukjin June 24, 2011, 6:48 a.m. UTC | #1
Russell King - ARM Linux wrote:
> 
> s3c_cpu_save does not need to save any registers with the new
> cpu_suspend calling convention.  Remove these redundant instructions.
> 
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

Tested-by: Kukjin Kim <kgene.kim@samsung.com>

It works fine on Samsung stuff with this whole series.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

> ---
>  arch/arm/plat-s3c24xx/sleep.S |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/plat-s3c24xx/sleep.S b/arch/arm/plat-s3c24xx/sleep.S
> index f822e62..6ada459 100644
> --- a/arch/arm/plat-s3c24xx/sleep.S
> +++ b/arch/arm/plat-s3c24xx/sleep.S
> @@ -48,10 +48,8 @@
>  	*/
> 
>  ENTRY(s3c_cpu_save)
> -	stmfd	sp!, { r4 - r12, lr }
>  	adr	r3, BSYM(s3c24xx_finish_suspend)
> -	bl	cpu_suspend
> -	ldmfd	sp!, { r4 - r12, pc }
> +	b	cpu_suspend
> 
>  s3c24xx_finish_suspend:
>  	@@ jump to final code to send system to sleep
> --
> 1.7.4.4
diff mbox

Patch

diff --git a/arch/arm/plat-s3c24xx/sleep.S b/arch/arm/plat-s3c24xx/sleep.S
index f822e62..6ada459 100644
--- a/arch/arm/plat-s3c24xx/sleep.S
+++ b/arch/arm/plat-s3c24xx/sleep.S
@@ -48,10 +48,8 @@ 
 	*/
 
 ENTRY(s3c_cpu_save)
-	stmfd	sp!, { r4 - r12, lr }
 	adr	r3, BSYM(s3c24xx_finish_suspend)
-	bl	cpu_suspend
-	ldmfd	sp!, { r4 - r12, pc }
+	b	cpu_suspend
 
 s3c24xx_finish_suspend:
 	@@ jump to final code to send system to sleep