diff mbox

drm/doc: Drop vblank_disable_allow wording

Message ID 1464093915-3935-1-git-send-email-daniel.vetter@ffwll.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Vetter May 24, 2016, 12:45 p.m. UTC
Forgot to update the docs when nuking that. Oops.

Fixes: fcee59065e58 ("drm: Nuke ->vblank_disable_allowed")
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 Documentation/DocBook/gpu.tmpl | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

Comments

Alex Deucher May 24, 2016, 2:24 p.m. UTC | #1
On Tue, May 24, 2016 at 8:45 AM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Forgot to update the docs when nuking that. Oops.
>
> Fixes: fcee59065e58 ("drm: Nuke ->vblank_disable_allowed")
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  Documentation/DocBook/gpu.tmpl | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/Documentation/DocBook/gpu.tmpl b/Documentation/DocBook/gpu.tmpl
> index 3306b4e931f7..cb130514cedf 100644
> --- a/Documentation/DocBook/gpu.tmpl
> +++ b/Documentation/DocBook/gpu.tmpl
> @@ -2829,14 +2829,7 @@ void (*disable_vblank) (struct drm_device *dev, int crtc);</synopsis>
>      <para>
>        Drivers must initialize the vertical blanking handling core with a call to
>        <function>drm_vblank_init</function> in their
> -      <methodname>load</methodname> operation. The function will set the struct
> -      <structname>drm_device</structname>
> -      <structfield>vblank_disable_allowed</structfield> field to 0. This will
> -      keep vertical blanking interrupts enabled permanently until the first mode
> -      set operation, where <structfield>vblank_disable_allowed</structfield> is
> -      set to 1. The reason behind this is not clear. Drivers can set the field
> -      to 1 after <function>calling drm_vblank_init</function> to make vertical
> -      blanking interrupts dynamically managed from the beginning.
> +      <methodname>load</methodname> operation.
>      </para>
>      <para>
>        Vertical blanking interrupts can be enabled by the DRM core or by drivers
> --
> 2.8.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Daniel Vetter May 24, 2016, 9:26 p.m. UTC | #2
On Tue, May 24, 2016 at 10:24:11AM -0400, Alex Deucher wrote:
> On Tue, May 24, 2016 at 8:45 AM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > Forgot to update the docs when nuking that. Oops.
> >
> > Fixes: fcee59065e58 ("drm: Nuke ->vblank_disable_allowed")
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> 
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

Applied to drm-misc, thanks for the review.
-Daniel

> 
> > ---
> >  Documentation/DocBook/gpu.tmpl | 9 +--------
> >  1 file changed, 1 insertion(+), 8 deletions(-)
> >
> > diff --git a/Documentation/DocBook/gpu.tmpl b/Documentation/DocBook/gpu.tmpl
> > index 3306b4e931f7..cb130514cedf 100644
> > --- a/Documentation/DocBook/gpu.tmpl
> > +++ b/Documentation/DocBook/gpu.tmpl
> > @@ -2829,14 +2829,7 @@ void (*disable_vblank) (struct drm_device *dev, int crtc);</synopsis>
> >      <para>
> >        Drivers must initialize the vertical blanking handling core with a call to
> >        <function>drm_vblank_init</function> in their
> > -      <methodname>load</methodname> operation. The function will set the struct
> > -      <structname>drm_device</structname>
> > -      <structfield>vblank_disable_allowed</structfield> field to 0. This will
> > -      keep vertical blanking interrupts enabled permanently until the first mode
> > -      set operation, where <structfield>vblank_disable_allowed</structfield> is
> > -      set to 1. The reason behind this is not clear. Drivers can set the field
> > -      to 1 after <function>calling drm_vblank_init</function> to make vertical
> > -      blanking interrupts dynamically managed from the beginning.
> > +      <methodname>load</methodname> operation.
> >      </para>
> >      <para>
> >        Vertical blanking interrupts can be enabled by the DRM core or by drivers
> > --
> > 2.8.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox

Patch

diff --git a/Documentation/DocBook/gpu.tmpl b/Documentation/DocBook/gpu.tmpl
index 3306b4e931f7..cb130514cedf 100644
--- a/Documentation/DocBook/gpu.tmpl
+++ b/Documentation/DocBook/gpu.tmpl
@@ -2829,14 +2829,7 @@  void (*disable_vblank) (struct drm_device *dev, int crtc);</synopsis>
     <para>
       Drivers must initialize the vertical blanking handling core with a call to
       <function>drm_vblank_init</function> in their
-      <methodname>load</methodname> operation. The function will set the struct
-      <structname>drm_device</structname>
-      <structfield>vblank_disable_allowed</structfield> field to 0. This will
-      keep vertical blanking interrupts enabled permanently until the first mode
-      set operation, where <structfield>vblank_disable_allowed</structfield> is
-      set to 1. The reason behind this is not clear. Drivers can set the field
-      to 1 after <function>calling drm_vblank_init</function> to make vertical
-      blanking interrupts dynamically managed from the beginning.
+      <methodname>load</methodname> operation.
     </para>
     <para>
       Vertical blanking interrupts can be enabled by the DRM core or by drivers