diff mbox

[22/27] drm/omapdrm: Nuke dummy fb->dirty callback

Message ID 1464630800-30786-23-git-send-email-daniel.vetter@ffwll.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Vetter May 30, 2016, 5:53 p.m. UTC
It's an optional hook.

Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/omapdrm/omap_fb.c | 8 --------
 1 file changed, 8 deletions(-)

Comments

Laurent Pinchart June 2, 2016, 10:52 p.m. UTC | #1
Hi Daniel,

Thank you for the patch.

On Monday 30 May 2016 19:53:14 Daniel Vetter wrote:
> It's an optional hook.
> 
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/omapdrm/omap_fb.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_fb.c
> b/drivers/gpu/drm/omapdrm/omap_fb.c index 94ec06d3d737..d639707f67db 100644
> --- a/drivers/gpu/drm/omapdrm/omap_fb.c
> +++ b/drivers/gpu/drm/omapdrm/omap_fb.c
> @@ -120,17 +120,9 @@ static void omap_framebuffer_destroy(struct
> drm_framebuffer *fb) kfree(omap_fb);
>  }
> 
> -static int omap_framebuffer_dirty(struct drm_framebuffer *fb,
> -		struct drm_file *file_priv, unsigned flags, unsigned color,
> -		struct drm_clip_rect *clips, unsigned num_clips)
> -{
> -	return 0;
> -}
> -
>  static const struct drm_framebuffer_funcs omap_framebuffer_funcs = {
>  	.create_handle = omap_framebuffer_create_handle,
>  	.destroy = omap_framebuffer_destroy,
> -	.dirty = omap_framebuffer_dirty,
>  };
> 
>  static uint32_t get_linear_addr(struct plane *plane,
diff mbox

Patch

diff --git a/drivers/gpu/drm/omapdrm/omap_fb.c b/drivers/gpu/drm/omapdrm/omap_fb.c
index 94ec06d3d737..d639707f67db 100644
--- a/drivers/gpu/drm/omapdrm/omap_fb.c
+++ b/drivers/gpu/drm/omapdrm/omap_fb.c
@@ -120,17 +120,9 @@  static void omap_framebuffer_destroy(struct drm_framebuffer *fb)
 	kfree(omap_fb);
 }
 
-static int omap_framebuffer_dirty(struct drm_framebuffer *fb,
-		struct drm_file *file_priv, unsigned flags, unsigned color,
-		struct drm_clip_rect *clips, unsigned num_clips)
-{
-	return 0;
-}
-
 static const struct drm_framebuffer_funcs omap_framebuffer_funcs = {
 	.create_handle = omap_framebuffer_create_handle,
 	.destroy = omap_framebuffer_destroy,
-	.dirty = omap_framebuffer_dirty,
 };
 
 static uint32_t get_linear_addr(struct plane *plane,