diff mbox

[37/38] drm/sti: Don't call drm_helper_disable_unused_functions

Message ID 1464818821-5736-38-git-send-email-daniel.vetter@ffwll.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Vetter June 1, 2016, 10:07 p.m. UTC
Atomic drivers are supposed to do hw/sw state reset with the
drm_mode_config_reset() call right above it.

Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/sti/sti_drv.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Benjamin Gaignard June 17, 2016, 10:04 a.m. UTC | #1
Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>

2016-06-02 0:07 GMT+02:00 Daniel Vetter <daniel.vetter@ffwll.ch>:
> Atomic drivers are supposed to do hw/sw state reset with the
> drm_mode_config_reset() call right above it.
>
> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/sti/sti_drv.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c
> index dd2c400c4a46..26aa85d4b872 100644
> --- a/drivers/gpu/drm/sti/sti_drv.c
> +++ b/drivers/gpu/drm/sti/sti_drv.c
> @@ -279,7 +279,6 @@ static int sti_load(struct drm_device *dev, unsigned long flags)
>
>         drm_mode_config_reset(dev);
>
> -       drm_helper_disable_unused_functions(dev);
>         drm_fbdev_cma_init(dev, 32,
>                            dev->mode_config.num_crtc,
>                            dev->mode_config.num_connector);
> --
> 2.8.1
>
Daniel Vetter June 17, 2016, 12:27 p.m. UTC | #2
On Fri, Jun 17, 2016 at 12:04:16PM +0200, Benjamin Gaignard wrote:
> Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>

Applied to drm-misc.
-Daniel

> 
> 2016-06-02 0:07 GMT+02:00 Daniel Vetter <daniel.vetter@ffwll.ch>:
> > Atomic drivers are supposed to do hw/sw state reset with the
> > drm_mode_config_reset() call right above it.
> >
> > Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > ---
> >  drivers/gpu/drm/sti/sti_drv.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c
> > index dd2c400c4a46..26aa85d4b872 100644
> > --- a/drivers/gpu/drm/sti/sti_drv.c
> > +++ b/drivers/gpu/drm/sti/sti_drv.c
> > @@ -279,7 +279,6 @@ static int sti_load(struct drm_device *dev, unsigned long flags)
> >
> >         drm_mode_config_reset(dev);
> >
> > -       drm_helper_disable_unused_functions(dev);
> >         drm_fbdev_cma_init(dev, 32,
> >                            dev->mode_config.num_crtc,
> >                            dev->mode_config.num_connector);
> > --
> > 2.8.1
> >
> 
> 
> 
> -- 
> Benjamin Gaignard
> 
> Graphic Working Group
> 
> Linaro.org │ Open source software for ARM SoCs
> 
> Follow Linaro: Facebook | Twitter | Blog
diff mbox

Patch

diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c
index dd2c400c4a46..26aa85d4b872 100644
--- a/drivers/gpu/drm/sti/sti_drv.c
+++ b/drivers/gpu/drm/sti/sti_drv.c
@@ -279,7 +279,6 @@  static int sti_load(struct drm_device *dev, unsigned long flags)
 
 	drm_mode_config_reset(dev);
 
-	drm_helper_disable_unused_functions(dev);
 	drm_fbdev_cma_init(dev, 32,
 			   dev->mode_config.num_crtc,
 			   dev->mode_config.num_connector);