| Message ID | 1464832099-22402-1-git-send-email-simhavcs@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 02 Jun 2016, Vinay Simha BN <simhavcs@gmail.com> wrote: > Provide a small convenience wrapper that transmits > ia set_tear_scanline command as suggested by > Thierry Reding. > > Also includes small build fixes from Sumit Semwal. > > Cc: Archit Taneja <archit.taneja@gmail.com> > Cc: John Stultz <john.stultz@linaro.org> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Sumit Semwal <sumit.semwal@linaro.org> > Signed-off-by: Vinay Simha BN <simhavcs@gmail.com> > --- > drivers/gpu/drm/drm_mipi_dsi.c | 23 +++++++++++++++++++++++ > include/drm/drm_mipi_dsi.h | 2 ++ > 2 files changed, 25 insertions(+) > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c > index f5d8083..2f0b85c 100644 > --- a/drivers/gpu/drm/drm_mipi_dsi.c > +++ b/drivers/gpu/drm/drm_mipi_dsi.c > @@ -983,6 +983,29 @@ int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi, > EXPORT_SYMBOL(mipi_dsi_dcs_set_tear_on); > > /** > + * mipi_dsi_set_tear_scanline() - turn on the display module's Tearing Effect > + * output signal on the TE signal line when display module reaches line N > + * defined by STS[n:0]. > + * @dsi: DSI peripheral device > + * @param1: STS[10:8] > + * @param2: STS[7:0] > + * Return: 0 on success or a negative error code on failure > + */ > +int mipi_dsi_set_tear_scanline(struct mipi_dsi_device *dsi, > + u8 param1, u8 param2) If you're making a helper, please make using it easy and have *one* scanline parameter. BR, Jani. > +{ > + u8 payload[3] = { MIPI_DCS_SET_TEAR_SCANLINE, param1, param2}; > + ssize_t err; > + > + err = mipi_dsi_generic_write(dsi, &payload, sizeof(payload)); > + if (err < 0) > + return err; > + > + return 0; > +} > +EXPORT_SYMBOL(mipi_dsi_set_tear_scanline); > + > +/** > * mipi_dsi_dcs_set_pixel_format() - sets the pixel format for the RGB image > * data used by the interface > * @dsi: DSI peripheral device > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index 7a9840f..2788dbe 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -263,6 +263,8 @@ int mipi_dsi_dcs_set_column_address(struct mipi_dsi_device *dsi, u16 start, > u16 end); > int mipi_dsi_dcs_set_page_address(struct mipi_dsi_device *dsi, u16 start, > u16 end); > +int mipi_dsi_set_tear_scanline(struct mipi_dsi_device *dsi, u8 param1, > + u8 param2); > int mipi_dsi_dcs_set_tear_off(struct mipi_dsi_device *dsi); > int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi, > enum mipi_dsi_dcs_tear_mode mode);
diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index f5d8083..2f0b85c 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -983,6 +983,29 @@ int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi, EXPORT_SYMBOL(mipi_dsi_dcs_set_tear_on); /** + * mipi_dsi_set_tear_scanline() - turn on the display module's Tearing Effect + * output signal on the TE signal line when display module reaches line N + * defined by STS[n:0]. + * @dsi: DSI peripheral device + * @param1: STS[10:8] + * @param2: STS[7:0] + * Return: 0 on success or a negative error code on failure + */ +int mipi_dsi_set_tear_scanline(struct mipi_dsi_device *dsi, + u8 param1, u8 param2) +{ + u8 payload[3] = { MIPI_DCS_SET_TEAR_SCANLINE, param1, param2}; + ssize_t err; + + err = mipi_dsi_generic_write(dsi, &payload, sizeof(payload)); + if (err < 0) + return err; + + return 0; +} +EXPORT_SYMBOL(mipi_dsi_set_tear_scanline); + +/** * mipi_dsi_dcs_set_pixel_format() - sets the pixel format for the RGB image * data used by the interface * @dsi: DSI peripheral device diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index 7a9840f..2788dbe 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -263,6 +263,8 @@ int mipi_dsi_dcs_set_column_address(struct mipi_dsi_device *dsi, u16 start, u16 end); int mipi_dsi_dcs_set_page_address(struct mipi_dsi_device *dsi, u16 start, u16 end); +int mipi_dsi_set_tear_scanline(struct mipi_dsi_device *dsi, u8 param1, + u8 param2); int mipi_dsi_dcs_set_tear_off(struct mipi_dsi_device *dsi); int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi, enum mipi_dsi_dcs_tear_mode mode);
Provide a small convenience wrapper that transmits ia set_tear_scanline command as suggested by Thierry Reding. Also includes small build fixes from Sumit Semwal. Cc: Archit Taneja <archit.taneja@gmail.com> Cc: John Stultz <john.stultz@linaro.org> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Sumit Semwal <sumit.semwal@linaro.org> Signed-off-by: Vinay Simha BN <simhavcs@gmail.com> --- drivers/gpu/drm/drm_mipi_dsi.c | 23 +++++++++++++++++++++++ include/drm/drm_mipi_dsi.h | 2 ++ 2 files changed, 25 insertions(+)