[RFC,v1,2/6] clk: rockchip: rk3399: add SCLK_DDRCLK ID for ddrc
diff mbox

Message ID 1464947719-6245-3-git-send-email-hl@rock-chips.com
State New
Headers show

Commit Message

huang lin June 3, 2016, 9:55 a.m. UTC
Signed-off-by: Lin Huang <hl@rock-chips.com>
---
Changes in v1:
- None

 include/dt-bindings/clock/rk3399-cru.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Shawn Lin June 3, 2016, 12:34 p.m. UTC | #1
Hi Lin

How about merge it into your patch#3.

On 2016/6/3 17:55, Lin Huang wrote:
> Signed-off-by: Lin Huang <hl@rock-chips.com>
> ---
> Changes in v1:
> - None
>
>  include/dt-bindings/clock/rk3399-cru.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/dt-bindings/clock/rk3399-cru.h b/include/dt-bindings/clock/rk3399-cru.h
> index 50a44cf..8a0f0442 100644
> --- a/include/dt-bindings/clock/rk3399-cru.h
> +++ b/include/dt-bindings/clock/rk3399-cru.h
> @@ -131,6 +131,7 @@
>  #define SCLK_DPHY_RX0_CFG		165
>  #define SCLK_RMII_SRC			166
>  #define SCLK_PCIEPHY_REF100M		167
> +#define SCLK_DDRCLK			168
>
>  #define DCLK_VOP0			180
>  #define DCLK_VOP1			181
>
Heiko Stübner June 3, 2016, 12:36 p.m. UTC | #2
Hi Shawn,

Am Freitag, 3. Juni 2016, 20:34:52 schrieb Shawn Lin:
> How about merge it into your patch#3.

see comments from Doug and me on previous version.

clock-ids should always be separate patches, as we will need them in both 
clock and devicetree branches, so they must be in a separate branch shared 
between clock and dts branches.


Heiko

> On 2016/6/3 17:55, Lin Huang wrote:
> > Signed-off-by: Lin Huang <hl@rock-chips.com>
> > ---
> > Changes in v1:
> > - None
> > 
> >  include/dt-bindings/clock/rk3399-cru.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/dt-bindings/clock/rk3399-cru.h
> > b/include/dt-bindings/clock/rk3399-cru.h index 50a44cf..8a0f0442 100644
> > --- a/include/dt-bindings/clock/rk3399-cru.h
> > +++ b/include/dt-bindings/clock/rk3399-cru.h
> > @@ -131,6 +131,7 @@
> > 
> >  #define SCLK_DPHY_RX0_CFG		165
> >  #define SCLK_RMII_SRC			166
> >  #define SCLK_PCIEPHY_REF100M		167
> > 
> > +#define SCLK_DDRCLK			168
> > 
> >  #define DCLK_VOP0			180
> >  #define DCLK_VOP1			181
Shawn Lin June 3, 2016, 12:47 p.m. UTC | #3
在 2016/6/3 20:36, Heiko Stübner 写道:
> Hi Shawn,
>
> Am Freitag, 3. Juni 2016, 20:34:52 schrieb Shawn Lin:
>> How about merge it into your patch#3.
>
> see comments from Doug and me on previous version.
>
> clock-ids should always be separate patches, as we will need them in both
> clock and devicetree branches, so they must be in a separate branch shared
> between clock and dts branches.
>

Ah, I missed the previous version as I think it should be from
non-version to v2 rather than from non-version to v1, which IIRC is from
Doug. :)

Anyway, thanks for explaining this.

>
> Heiko
>
>> On 2016/6/3 17:55, Lin Huang wrote:
>>> Signed-off-by: Lin Huang <hl@rock-chips.com>
>>> ---
>>> Changes in v1:
>>> - None
>>>
>>>  include/dt-bindings/clock/rk3399-cru.h | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/include/dt-bindings/clock/rk3399-cru.h
>>> b/include/dt-bindings/clock/rk3399-cru.h index 50a44cf..8a0f0442 100644
>>> --- a/include/dt-bindings/clock/rk3399-cru.h
>>> +++ b/include/dt-bindings/clock/rk3399-cru.h
>>> @@ -131,6 +131,7 @@
>>>
>>>  #define SCLK_DPHY_RX0_CFG		165
>>>  #define SCLK_RMII_SRC			166
>>>  #define SCLK_PCIEPHY_REF100M		167
>>>
>>> +#define SCLK_DDRCLK			168
>>>
>>>  #define DCLK_VOP0			180
>>>  #define DCLK_VOP1			181
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
Douglas Anderson June 3, 2016, 1:25 p.m. UTC | #4
Hi,

On Fri, Jun 3, 2016 at 5:47 AM, Shawn Lin <shawn.lin@rock-chips.com> wrote:
> Ah, I missed the previous version as I think it should be from
> non-version to v2 rather than from non-version to v1, which IIRC is from
> Doug. :)

Yup, patch-numbering is 1-based, not 0-based, so typically you have
no-version => v2 => v3 => v99

-Doug

Patch
diff mbox

diff --git a/include/dt-bindings/clock/rk3399-cru.h b/include/dt-bindings/clock/rk3399-cru.h
index 50a44cf..8a0f0442 100644
--- a/include/dt-bindings/clock/rk3399-cru.h
+++ b/include/dt-bindings/clock/rk3399-cru.h
@@ -131,6 +131,7 @@ 
 #define SCLK_DPHY_RX0_CFG		165
 #define SCLK_RMII_SRC			166
 #define SCLK_PCIEPHY_REF100M		167
+#define SCLK_DDRCLK			168
 
 #define DCLK_VOP0			180
 #define DCLK_VOP1			181