[v2,14/15] drm/i2c/ch7006: Use helper to turn off CRTC
diff mbox

Message ID ec7d5c06e2a21dfb8f9fc9413d3e6df86d6aa1fb.1465392124.git.lukas@wunner.de
State New
Headers show

Commit Message

Lukas Wunner June 8, 2016, 4:47 p.m. UTC
Use shiny new drm_crtc_force_disable() instead of open coding the same.
No functional change intended.

Cc: Francisco Jerez <currojerez@riseup.net>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
---
 drivers/gpu/drm/i2c/ch7006_drv.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

Comments

Francisco Jerez June 11, 2016, 9:57 p.m. UTC | #1
Lukas Wunner <lukas@wunner.de> writes:

> Use shiny new drm_crtc_force_disable() instead of open coding the same.
> No functional change intended.
>
> Cc: Francisco Jerez <currojerez@riseup.net>
> Signed-off-by: Lukas Wunner <lukas@wunner.de>

Reviewed-by: Francisco Jerez <currojerez@riseup.net>

> ---
>  drivers/gpu/drm/i2c/ch7006_drv.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch7006_drv.c
> index 0594c45..e9e8ae2 100644
> --- a/drivers/gpu/drm/i2c/ch7006_drv.c
> +++ b/drivers/gpu/drm/i2c/ch7006_drv.c
> @@ -361,13 +361,8 @@ static int ch7006_encoder_set_property(struct drm_encoder *encoder,
>  
>  		/* Disable the crtc to ensure a full modeset is
>  		 * performed whenever it's turned on again. */
> -		if (crtc) {
> -			struct drm_mode_set modeset = {
> -				.crtc = crtc,
> -			};
> -
> -			drm_mode_set_config_internal(&modeset);
> -		}
> +		if (crtc)
> +			drm_crtc_force_disable(crtc);
>  	}
>  
>  	return 0;
> -- 
> 2.8.1

Patch
diff mbox

diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch7006_drv.c
index 0594c45..e9e8ae2 100644
--- a/drivers/gpu/drm/i2c/ch7006_drv.c
+++ b/drivers/gpu/drm/i2c/ch7006_drv.c
@@ -361,13 +361,8 @@  static int ch7006_encoder_set_property(struct drm_encoder *encoder,
 
 		/* Disable the crtc to ensure a full modeset is
 		 * performed whenever it's turned on again. */
-		if (crtc) {
-			struct drm_mode_set modeset = {
-				.crtc = crtc,
-			};
-
-			drm_mode_set_config_internal(&modeset);
-		}
+		if (crtc)
+			drm_crtc_force_disable(crtc);
 	}
 
 	return 0;