Message ID | 1465844702-12200-10-git-send-email-t-kristo@ti.com (mailing list archive) |
---|---|
State | Changes Requested |
Delegated to: | Stephen Boyd |
Headers | show |
* Tero Kristo <t-kristo@ti.com> [160613 12:08]: > If the module has no clkctrl register defined, module_wait_ready should > not try to access this. This can potentially cause an illegal register > access, and result in bad idle reporting also. Acked-by: Tony Lindgren <tony@atomide.com> Seems at least this one I could take separately. Probably best that we merge the arch/arm/mach-omap2 changes first that can be done until there's some conclusion to the ti_clk_get() comments I made. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-omap2/cm33xx.c b/arch/arm/mach-omap2/cm33xx.c index 7b181f9..c073fb5 100644 --- a/arch/arm/mach-omap2/cm33xx.c +++ b/arch/arm/mach-omap2/cm33xx.c @@ -220,6 +220,9 @@ static int am33xx_cm_wait_module_ready(u8 part, s16 inst, u16 clkctrl_offs, { int i = 0; + if (!clkctrl_offs) + return 0; + omap_test_timeout(_is_module_ready(inst, clkctrl_offs), MAX_MODULE_READY_TIME, i);
If the module has no clkctrl register defined, module_wait_ready should not try to access this. This can potentially cause an illegal register access, and result in bad idle reporting also. Signed-off-by: Tero Kristo <t-kristo@ti.com> --- arch/arm/mach-omap2/cm33xx.c | 3 +++ 1 file changed, 3 insertions(+)