kbuild: List libelf-devel as an alternative
diff mbox

Message ID 20160616105420.13b4dbf2@endymion
State New
Headers show

Commit Message

Jean Delvare June 16, 2016, 8:54 a.m. UTC
On openSUSE, the libelf development files are in package libelf-devel.

Signed-off-by: Jean Delare <jdelvare@suse.de>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Michal Marek <mmarek@suse.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
---
 Makefile                   |    2 +-
 tools/perf/config/Makefile |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Josh Poimboeuf June 16, 2016, 3:08 p.m. UTC | #1
On Thu, Jun 16, 2016 at 10:54:20AM +0200, Jean Delvare wrote:
> On openSUSE, the libelf development files are in package libelf-devel.
> 
> Signed-off-by: Jean Delare <jdelvare@suse.de>
> Cc: Josh Poimboeuf <jpoimboe@redhat.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Michal Marek <mmarek@suse.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>

Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>

> ---
>  Makefile                   |    2 +-
>  tools/perf/config/Makefile |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-4.6.orig/Makefile	2016-05-16 00:43:13.000000000 +0200
> +++ linux-4.6/Makefile	2016-06-16 10:42:26.990587718 +0200
> @@ -1013,7 +1013,7 @@ ifdef CONFIG_STACK_VALIDATION
>    ifeq ($(has_libelf),1)
>      objtool_target := tools/objtool FORCE
>    else
> -    $(warning "Cannot use CONFIG_STACK_VALIDATION, please install libelf-dev or elfutils-libelf-devel")
> +    $(warning "Cannot use CONFIG_STACK_VALIDATION, please install libelf-dev, libelf-devel or elfutils-libelf-devel")
>      SKIP_STACK_VALIDATION := 1
>      export SKIP_STACK_VALIDATION
>    endif
> --- linux-4.6.orig/tools/perf/config/Makefile	2016-05-16 00:43:13.000000000 +0200
> +++ linux-4.6/tools/perf/config/Makefile	2016-06-16 10:43:29.517409971 +0200
> @@ -243,7 +243,7 @@ else
>        LIBC_SUPPORT := 1
>      endif
>      ifeq ($(LIBC_SUPPORT),1)
> -      msg := $(warning No libelf found, disables 'probe' tool and BPF support in 'perf record', please install elfutils-libelf-devel/libelf-dev);
> +      msg := $(warning No libelf found, disables 'probe' tool and BPF support in 'perf record', please install libelf-dev, libelf-devel or elfutils-libelf-devel);
>  
>        NO_LIBELF := 1
>        NO_DWARF := 1
> 
> 
> -- 
> Jean Delvare
> SUSE L3 Support
Arnaldo Carvalho de Melo June 16, 2016, 4:38 p.m. UTC | #2
Em Thu, Jun 16, 2016 at 10:08:09AM -0500, Josh Poimboeuf escreveu:
> On Thu, Jun 16, 2016 at 10:54:20AM +0200, Jean Delvare wrote:
> > On openSUSE, the libelf development files are in package libelf-devel.
> > 
> > Signed-off-by: Jean Delare <jdelvare@suse.de>
> > Cc: Josh Poimboeuf <jpoimboe@redhat.com>
> > Cc: Jiri Olsa <jolsa@redhat.com>
> > Cc: Michal Marek <mmarek@suse.com>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> 
> Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>

Thanks, applying.

- Arnaldo
 
> > ---
> >  Makefile                   |    2 +-
> >  tools/perf/config/Makefile |    2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > --- linux-4.6.orig/Makefile	2016-05-16 00:43:13.000000000 +0200
> > +++ linux-4.6/Makefile	2016-06-16 10:42:26.990587718 +0200
> > @@ -1013,7 +1013,7 @@ ifdef CONFIG_STACK_VALIDATION
> >    ifeq ($(has_libelf),1)
> >      objtool_target := tools/objtool FORCE
> >    else
> > -    $(warning "Cannot use CONFIG_STACK_VALIDATION, please install libelf-dev or elfutils-libelf-devel")
> > +    $(warning "Cannot use CONFIG_STACK_VALIDATION, please install libelf-dev, libelf-devel or elfutils-libelf-devel")
> >      SKIP_STACK_VALIDATION := 1
> >      export SKIP_STACK_VALIDATION
> >    endif
> > --- linux-4.6.orig/tools/perf/config/Makefile	2016-05-16 00:43:13.000000000 +0200
> > +++ linux-4.6/tools/perf/config/Makefile	2016-06-16 10:43:29.517409971 +0200
> > @@ -243,7 +243,7 @@ else
> >        LIBC_SUPPORT := 1
> >      endif
> >      ifeq ($(LIBC_SUPPORT),1)
> > -      msg := $(warning No libelf found, disables 'probe' tool and BPF support in 'perf record', please install elfutils-libelf-devel/libelf-dev);
> > +      msg := $(warning No libelf found, disables 'probe' tool and BPF support in 'perf record', please install libelf-dev, libelf-devel or elfutils-libelf-devel);
> >  
> >        NO_LIBELF := 1
> >        NO_DWARF := 1
> > 
> > 
> > -- 
> > Jean Delvare
> > SUSE L3 Support
> 
> -- 
> Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

--- linux-4.6.orig/Makefile	2016-05-16 00:43:13.000000000 +0200
+++ linux-4.6/Makefile	2016-06-16 10:42:26.990587718 +0200
@@ -1013,7 +1013,7 @@  ifdef CONFIG_STACK_VALIDATION
   ifeq ($(has_libelf),1)
     objtool_target := tools/objtool FORCE
   else
-    $(warning "Cannot use CONFIG_STACK_VALIDATION, please install libelf-dev or elfutils-libelf-devel")
+    $(warning "Cannot use CONFIG_STACK_VALIDATION, please install libelf-dev, libelf-devel or elfutils-libelf-devel")
     SKIP_STACK_VALIDATION := 1
     export SKIP_STACK_VALIDATION
   endif
--- linux-4.6.orig/tools/perf/config/Makefile	2016-05-16 00:43:13.000000000 +0200
+++ linux-4.6/tools/perf/config/Makefile	2016-06-16 10:43:29.517409971 +0200
@@ -243,7 +243,7 @@  else
       LIBC_SUPPORT := 1
     endif
     ifeq ($(LIBC_SUPPORT),1)
-      msg := $(warning No libelf found, disables 'probe' tool and BPF support in 'perf record', please install elfutils-libelf-devel/libelf-dev);
+      msg := $(warning No libelf found, disables 'probe' tool and BPF support in 'perf record', please install libelf-dev, libelf-devel or elfutils-libelf-devel);
 
       NO_LIBELF := 1
       NO_DWARF := 1