ASoC: core: Remove selects of regmap buses
diff mbox

Message ID 1466168669-13140-1-git-send-email-broonie@kernel.org
State New
Headers show

Commit Message

Mark Brown June 17, 2016, 1:04 p.m. UTC
We used to have code wrapping the regmap I2C and SPI buses as part of
the conversion of ASoC drivers from using the ASoC level I/O to the
regmap level I/O.  Since all drivers have now been converted and the
core code removed we can remove the per-bus selects and instead just
select the regmap core.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Lars-Peter Clausen June 18, 2016, 5:43 p.m. UTC | #1
On 06/17/2016 03:04 PM, Mark Brown wrote:
> We used to have code wrapping the regmap I2C and SPI buses as part of
> the conversion of ASoC drivers from using the ASoC level I/O to the
> regmap level I/O.  Since all drivers have now been converted and the
> core code removed we can remove the per-bus selects and instead just
> select the regmap core.

I think there is a fair amount of CODEC drivers that don't yet select
REGMAP_{SPI,I2C} even though they use it. Merging this as is would break
them I'd assume.
Mark Brown June 20, 2016, 3:44 p.m. UTC | #2
On Sat, Jun 18, 2016 at 07:43:10PM +0200, Lars-Peter Clausen wrote:
> On 06/17/2016 03:04 PM, Mark Brown wrote:

> > We used to have code wrapping the regmap I2C and SPI buses as part of
> > the conversion of ASoC drivers from using the ASoC level I/O to the
> > regmap level I/O.  Since all drivers have now been converted and the
> > core code removed we can remove the per-bus selects and instead just
> > select the regmap core.

> I think there is a fair amount of CODEC drivers that don't yet select
> REGMAP_{SPI,I2C} even though they use it. Merging this as is would break
> them I'd assume.

Yes, that's why I've not actually applied this yet.

Patch
diff mbox

diff --git a/sound/soc/Kconfig b/sound/soc/Kconfig
index 182d92efc7c8..4935e23ff3d6 100644
--- a/sound/soc/Kconfig
+++ b/sound/soc/Kconfig
@@ -7,8 +7,7 @@  menuconfig SND_SOC
 	select SND_PCM
 	select AC97_BUS if SND_SOC_AC97_BUS
 	select SND_JACK
-	select REGMAP_I2C if I2C
-	select REGMAP_SPI if SPI_MASTER
+	select REGMAP
 	---help---
 
 	  If you want ASoC support, you should say Y here and also to the