diff mbox

drm/amdgpu: precedence bug in amdgpu_device_init()

Message ID 20160618083844.GA21713@mwanda (mailing list archive)
State New, archived
Headers show

Commit Message

Dan Carpenter June 18, 2016, 8:38 a.m. UTC 
! has higher precedence than bitwise & so we need to add parenthesis
for this to work as intended.

Fixes: 048765ad5af7 ('amdgpu: fix asic initialization for virtualized environments (v2)')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

Alex Deucher June 20, 2016, 9:06 p.m. UTC | #1 
On Sat, Jun 18, 2016 at 4:38 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> ! has higher precedence than bitwise & so we need to add parenthesis
> for this to work as intended.
>
> Fixes: 048765ad5af7 ('amdgpu: fix asic initialization for virtualized environments (v2)')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.  thanks!

Alex

>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 66482b4..6e92008 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1535,7 +1535,7 @@ int amdgpu_device_init(struct amdgpu_device *adev,
>         /* Post card if necessary */
>         if (!amdgpu_card_posted(adev) ||
>             (adev->virtualization.is_virtual &&
> -            !adev->virtualization.caps & AMDGPU_VIRT_CAPS_SRIOV_EN)) {
> +            !(adev->virtualization.caps & AMDGPU_VIRT_CAPS_SRIOV_EN))) {
>                 if (!adev->bios) {
>                         dev_err(adev->dev, "Card not posted and no BIOS - ignoring\n");
>                         return -EINVAL;
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox

Patch

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 66482b4..6e92008 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -1535,7 +1535,7 @@  int amdgpu_device_init(struct amdgpu_device *adev,
 	/* Post card if necessary */
 	if (!amdgpu_card_posted(adev) ||
 	    (adev->virtualization.is_virtual &&
-	     !adev->virtualization.caps & AMDGPU_VIRT_CAPS_SRIOV_EN)) {
+	     !(adev->virtualization.caps & AMDGPU_VIRT_CAPS_SRIOV_EN))) {
 		if (!adev->bios) {
 			dev_err(adev->dev, "Card not posted and no BIOS - ignoring\n");
 			return -EINVAL;