diff mbox

drm/hisilicon: add select HISI_KIRIN_DW_DSI

Message ID 20160620035903.244616-1-xinliang.liu@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Xinliang Liu June 20, 2016, 3:59 a.m. UTC
From: Guodong Xu <guodong.xu@linaro.org>

Add select HISI_KIRIN_DW_DSI to Kconfig.
The DRM driver depends on dsi sub-driver.

Signed-off-by: Zoltan Kuscsik <zoltan.kuscsik@linaro.org>
---
 drivers/gpu/drm/hisilicon/kirin/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Thierry Reding June 21, 2016, 1:34 p.m. UTC | #1
On Mon, Jun 20, 2016 at 11:59:03AM +0800, Xinliang Liu wrote:
> From: Guodong Xu <guodong.xu@linaro.org>
> 
> Add select HISI_KIRIN_DW_DSI to Kconfig.
> The DRM driver depends on dsi sub-driver.
> 
> Signed-off-by: Zoltan Kuscsik <zoltan.kuscsik@linaro.org>
> ---
>  drivers/gpu/drm/hisilicon/kirin/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

You've got the Signed-off-by area messed up. If Guodong wrote this patch
that his Signed-off-by needs to be added. Your Signed-off by should also
be added because you forwarded the patch to the mailing list.

Thierry
Guodong Xu June 22, 2016, 12:54 a.m. UTC | #2
On 21 June 2016 at 21:34, Thierry Reding <thierry.reding@gmail.com> wrote:
> On Mon, Jun 20, 2016 at 11:59:03AM +0800, Xinliang Liu wrote:
>> From: Guodong Xu <guodong.xu@linaro.org>
>>
>> Add select HISI_KIRIN_DW_DSI to Kconfig.
>> The DRM driver depends on dsi sub-driver.
>>
>> Signed-off-by: Zoltan Kuscsik <zoltan.kuscsik@linaro.org>
>> ---
>>  drivers/gpu/drm/hisilicon/kirin/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>
> You've got the Signed-off-by area messed up. If Guodong wrote this patch

Hi, Xinliang,

To clarify this, you don't need my Signed-off. Zoltan is the author,
and I am just the person who ever integrated that patch into my local
tree.

-Guodong

> that his Signed-off-by needs to be added. Your Signed-off by should also
> be added because you forwarded the patch to the mailing list.
>
> Thierry
Xinliang Liu June 22, 2016, 2:34 a.m. UTC | #3
Hi,

On 21 June 2016 at 21:34, Thierry Reding <thierry.reding@gmail.com> wrote:
> On Mon, Jun 20, 2016 at 11:59:03AM +0800, Xinliang Liu wrote:
>> From: Guodong Xu <guodong.xu@linaro.org>
>>
>> Add select HISI_KIRIN_DW_DSI to Kconfig.
>> The DRM driver depends on dsi sub-driver.
>>
>> Signed-off-by: Zoltan Kuscsik <zoltan.kuscsik@linaro.org>
>> ---
>>  drivers/gpu/drm/hisilicon/kirin/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>
> You've got the Signed-off-by area messed up. If Guodong wrote this patch
> that his Signed-off-by needs to be added. Your Signed-off by should also
> be added because you forwarded the patch to the mailing list.

Thierry, yes, you are right. I should add a Signed-off-by in the patch.

Thanks,
-xinliang

>
> Thierry
Xinliang Liu June 22, 2016, 2:35 a.m. UTC | #4
On 22 June 2016 at 08:54, Guodong Xu <guodong.xu@linaro.org> wrote:
> On 21 June 2016 at 21:34, Thierry Reding <thierry.reding@gmail.com> wrote:
>> On Mon, Jun 20, 2016 at 11:59:03AM +0800, Xinliang Liu wrote:
>>> From: Guodong Xu <guodong.xu@linaro.org>
>>>
>>> Add select HISI_KIRIN_DW_DSI to Kconfig.
>>> The DRM driver depends on dsi sub-driver.
>>>
>>> Signed-off-by: Zoltan Kuscsik <zoltan.kuscsik@linaro.org>
>>> ---
>>>  drivers/gpu/drm/hisilicon/kirin/Kconfig | 1 +
>>>  1 file changed, 1 insertion(+)
>>
>> You've got the Signed-off-by area messed up. If Guodong wrote this patch
>
> Hi, Xinliang,
>
> To clarify this, you don't need my Signed-off. Zoltan is the author,
> and I am just the person who ever integrated that patch into my local
> tree.

OK, Guodong.
Thanks,
-xinliang

>
> -Guodong
>
>> that his Signed-off-by needs to be added. Your Signed-off by should also
>> be added because you forwarded the patch to the mailing list.
>>
>> Thierry
Thierry Reding June 22, 2016, 12:59 p.m. UTC | #5
On Wed, Jun 22, 2016 at 08:54:02AM +0800, Guodong Xu wrote:
> On 21 June 2016 at 21:34, Thierry Reding <thierry.reding@gmail.com> wrote:
> > On Mon, Jun 20, 2016 at 11:59:03AM +0800, Xinliang Liu wrote:
> >> From: Guodong Xu <guodong.xu@linaro.org>
> >>
> >> Add select HISI_KIRIN_DW_DSI to Kconfig.
> >> The DRM driver depends on dsi sub-driver.
> >>
> >> Signed-off-by: Zoltan Kuscsik <zoltan.kuscsik@linaro.org>
> >> ---
> >>  drivers/gpu/drm/hisilicon/kirin/Kconfig | 1 +
> >>  1 file changed, 1 insertion(+)
> >
> > You've got the Signed-off-by area messed up. If Guodong wrote this patch
> 
> Hi, Xinliang,
> 
> To clarify this, you don't need my Signed-off. Zoltan is the author,
> and I am just the person who ever integrated that patch into my local
> tree.

If Zoltan is the author, then his name should be in the From: line
above. As it is, git am will apply this with you as author. Also, see
section 11) in Documentation/SubmittingPatches on why you need to add
your S-o-b as well.

Thierry
Xinliang Liu June 29, 2016, 9:08 a.m. UTC | #6
Hi,

On 22 June 2016 at 20:59, Thierry Reding <thierry.reding@gmail.com> wrote:
> On Wed, Jun 22, 2016 at 08:54:02AM +0800, Guodong Xu wrote:
>> On 21 June 2016 at 21:34, Thierry Reding <thierry.reding@gmail.com> wrote:
>> > On Mon, Jun 20, 2016 at 11:59:03AM +0800, Xinliang Liu wrote:
>> >> From: Guodong Xu <guodong.xu@linaro.org>
>> >>
>> >> Add select HISI_KIRIN_DW_DSI to Kconfig.
>> >> The DRM driver depends on dsi sub-driver.
>> >>
>> >> Signed-off-by: Zoltan Kuscsik <zoltan.kuscsik@linaro.org>
>> >> ---
>> >>  drivers/gpu/drm/hisilicon/kirin/Kconfig | 1 +
>> >>  1 file changed, 1 insertion(+)
>> >
>> > You've got the Signed-off-by area messed up. If Guodong wrote this patch
>>
>> Hi, Xinliang,
>>
>> To clarify this, you don't need my Signed-off. Zoltan is the author,
>> and I am just the person who ever integrated that patch into my local
>> tree.
>
> If Zoltan is the author, then his name should be in the From: line
> above. As it is, git am will apply this with you as author. Also, see
> section 11) in Documentation/SubmittingPatches on why you need to add
> your S-o-b as well.

Thierry, that's right. I will resent the patch in the author of zoltan
and adding my s-o-b.

Thanks,
-xinliang

>
> Thierry
diff mbox

Patch

diff --git a/drivers/gpu/drm/hisilicon/kirin/Kconfig b/drivers/gpu/drm/hisilicon/kirin/Kconfig
index ea0df6115f7e..499f64405dac 100644
--- a/drivers/gpu/drm/hisilicon/kirin/Kconfig
+++ b/drivers/gpu/drm/hisilicon/kirin/Kconfig
@@ -4,6 +4,7 @@  config DRM_HISI_KIRIN
 	select DRM_KMS_HELPER
 	select DRM_GEM_CMA_HELPER
 	select DRM_KMS_CMA_HELPER
+	select HISI_KIRIN_DW_DSI
 	help
 	  Choose this option if you have a hisilicon Kirin chipsets(hi6220).
 	  If M is selected the module will be called kirin-drm.