| Message ID | 1466416292-9615-1-git-send-email-laurent@vivier.eu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 06/20/2016 03:51 AM, Laurent Vivier wrote: > Display an exception number, generally defined as an hexadecimal > number (for instance, EXCP_HLT is 0x10001). > > Signed-off-by: Laurent Vivier <laurent@vivier.eu> > --- > Resent to fix qemu-trivial email address. > > linux-user/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Eric Blake <eblake@redhat.com> Can you also fix the occurrence of 0x%d in trace-events, for mhp_pc_dimm_assigned_slot()? (Or whatever file it lands in after the trace-events split pull request) > diff --git a/linux-user/main.c b/linux-user/main.c > index b9a4e0e..c79f5cb 100644 > --- a/linux-user/main.c > +++ b/linux-user/main.c > @@ -2036,7 +2036,7 @@ void cpu_loop(CPUPPCState *env) > /* just indicate that signals should be handled asap */ > break; > default: > - cpu_abort(cs, "Unknown exception 0x%d. Aborting\n", trapnr); > + cpu_abort(cs, "Unknown exception 0x%x. Aborting\n", trapnr); > break; > } > process_pending_signals(env); >
Le 20/06/2016 à 18:49, Eric Blake a écrit : > On 06/20/2016 03:51 AM, Laurent Vivier wrote: >> Display an exception number, generally defined as an hexadecimal >> number (for instance, EXCP_HLT is 0x10001). >> >> Signed-off-by: Laurent Vivier <laurent@vivier.eu> >> --- >> Resent to fix qemu-trivial email address. >> >> linux-user/main.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> > > Reviewed-by: Eric Blake <eblake@redhat.com> > > Can you also fix the occurrence of 0x%d in trace-events, for > mhp_pc_dimm_assigned_slot()? (Or whatever file it lands in after the > trace-events split pull request) Yes, after the after split pull request. Thanks, Laurent > >> diff --git a/linux-user/main.c b/linux-user/main.c >> index b9a4e0e..c79f5cb 100644 >> --- a/linux-user/main.c >> +++ b/linux-user/main.c >> @@ -2036,7 +2036,7 @@ void cpu_loop(CPUPPCState *env) >> /* just indicate that signals should be handled asap */ >> break; >> default: >> - cpu_abort(cs, "Unknown exception 0x%d. Aborting\n", trapnr); >> + cpu_abort(cs, "Unknown exception 0x%x. Aborting\n", trapnr); >> break; >> } >> process_pending_signals(env); >> >
On Mon, Jun 20, 2016 at 11:51:32AM +0200, Laurent Vivier wrote: > Display an exception number, generally defined as an hexadecimal > number (for instance, EXCP_HLT is 0x10001). Acked-by: Riku Voipio <riku.voipio@linaro.org> > Signed-off-by: Laurent Vivier <laurent@vivier.eu> > --- > Resent to fix qemu-trivial email address. > > linux-user/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/linux-user/main.c b/linux-user/main.c > index b9a4e0e..c79f5cb 100644 > --- a/linux-user/main.c > +++ b/linux-user/main.c > @@ -2036,7 +2036,7 @@ void cpu_loop(CPUPPCState *env) > /* just indicate that signals should be handled asap */ > break; > default: > - cpu_abort(cs, "Unknown exception 0x%d. Aborting\n", trapnr); > + cpu_abort(cs, "Unknown exception 0x%x. Aborting\n", trapnr); > break; > } > process_pending_signals(env); > -- > 2.5.5 >
20.06.2016 12:51, Laurent Vivier wrote: > Display an exception number, generally defined as an hexadecimal > number (for instance, EXCP_HLT is 0x10001). Applied to -trivial, thanks! /mjt
diff --git a/linux-user/main.c b/linux-user/main.c index b9a4e0e..c79f5cb 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -2036,7 +2036,7 @@ void cpu_loop(CPUPPCState *env) /* just indicate that signals should be handled asap */ break; default: - cpu_abort(cs, "Unknown exception 0x%d. Aborting\n", trapnr); + cpu_abort(cs, "Unknown exception 0x%x. Aborting\n", trapnr); break; } process_pending_signals(env);
Display an exception number, generally defined as an hexadecimal number (for instance, EXCP_HLT is 0x10001). Signed-off-by: Laurent Vivier <laurent@vivier.eu> --- Resent to fix qemu-trivial email address. linux-user/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)