From patchwork Mon Jun 20 17:56:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 9188465 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5FB366089D for ; Mon, 20 Jun 2016 18:27:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 532772780C for ; Mon, 20 Jun 2016 18:27:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 47EE027C14; Mon, 20 Jun 2016 18:27:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C43B02780C for ; Mon, 20 Jun 2016 18:27:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755904AbcFTS04 (ORCPT ); Mon, 20 Jun 2016 14:26:56 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:33930 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755139AbcFTS0k (ORCPT ); Mon, 20 Jun 2016 14:26:40 -0400 Received: by mail-pf0-f173.google.com with SMTP id h14so41301863pfe.1 for ; Mon, 20 Jun 2016 11:26:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4w0KHfE3CxA3sRtTe9Rs9fsUdr25mnkervEAvbnH4b4=; b=mJ5ax//YopDVOORhytt5EKXxVLgwcpHnsdtRSqdR6KjZkdnHPRKVzjqNK5fLojtD75 iEuhHiE7/XaslXOHFsmg5kVnXFGACxEaWa2rYmdZfWPGjHVm6nG5QaAPHfw2yNOuST6a A/QAV+58ZDonO1dS2waryCL6H10Rnh8QOjEls= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4w0KHfE3CxA3sRtTe9Rs9fsUdr25mnkervEAvbnH4b4=; b=XcOhS+qEsc1qdDCx65QLYJwHURiLuh2Evq+SaxuMwGxmJ3KPQ0H1tg+tx1h+/M8vPn k0Vi1AhMW2xVDOAGUe9R3chlUXQcbxUNQxX3vJt9KIM9Lusl5iI4nQq4Zp9DogYskulo PUIvz+ZJ/nCYCw2SuVbjEtwB+WRhigjgCU3c/zdHAvEzxR3IVG86UPJMqKSZ7aWu2YxH dNJAJ2jYkE/wVHQD27bQDANWQyQIsUm/bUUqv8z7NpfMSx1ShNlfWn7a4X3yPJRTibix WxnuLegdrGqA2YMXcMvfcLeH5oL/oBqlgrTOPuV+gEdK2/2ZO+/HH50M4hj1lBMQt9yi Mb9A== X-Gm-Message-State: ALyK8tL6h9hivChUDQCuRH4x+Rfp/whnokWME+0dyUzkLNAMwOwjcZ4XjozVvSh+wDT+iZR/ X-Received: by 10.98.25.66 with SMTP id 63mr23024072pfz.94.1466445632727; Mon, 20 Jun 2016 11:00:32 -0700 (PDT) Received: from tictac.mtv.corp.google.com ([172.22.65.76]) by smtp.gmail.com with ESMTPSA id c189sm60250353pfg.19.2016.06.20.11.00.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 20 Jun 2016 11:00:31 -0700 (PDT) From: Douglas Anderson To: ulf.hansson@linaro.org, Heiko Stuebner Cc: kishon@ti.com, robh+dt@kernel.org, shawn.lin@rock-chips.com, xzy.xu@rock-chips.com, briannorris@chromium.org, adrian.hunter@intel.com, linux-rockchip@lists.infradead.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, groeck@chromium.org, Douglas Anderson , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 01/15] phy: rockchip-emmc: give DLL some extra time to be ready Date: Mon, 20 Jun 2016 10:56:40 -0700 Message-Id: <1466445414-11974-2-git-send-email-dianders@chromium.org> X-Mailer: git-send-email 2.8.0.rc3.226.g39d4020 In-Reply-To: <1466445414-11974-1-git-send-email-dianders@chromium.org> References: <1466445414-11974-1-git-send-email-dianders@chromium.org> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Shawn Lin According to the databook, 10.2us is the max time for dll to be ready to work. However in testing, some chips need 20us for dll to be ready. This patch adds some extra margin for dllrdy to be ready, fixing our -ETIMEDOUT issues. Signed-off-by: Shawn Lin Signed-off-by: Brian Norris Signed-off-by: Douglas Anderson Acked-by: Kishon Vijay Abraham I Tested-by: Heiko Stuebner --- Changes in v3: - Add Brian's PHY patches into my series Changes in v2: None drivers/phy/phy-rockchip-emmc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/phy/phy-rockchip-emmc.c b/drivers/phy/phy-rockchip-emmc.c index 6ebcf3e41c46..48cbe691a889 100644 --- a/drivers/phy/phy-rockchip-emmc.c +++ b/drivers/phy/phy-rockchip-emmc.c @@ -119,10 +119,11 @@ static int rockchip_emmc_phy_power(struct rockchip_emmc_phy *rk_phy, PHYCTRL_ENDLL_MASK, PHYCTRL_ENDLL_SHIFT)); /* - * After enable analog DLL circuits, we need extra 10.2us - * for dll to be ready for work. + * After enable analog DLL circuits, we need an extra 10.2us + * for dll to be ready for work. But according to testing, we + * find some chips need more than 25us. */ - udelay(11); + udelay(30); regmap_read(rk_phy->reg_base, rk_phy->reg_offset + GRF_EMMCPHY_STATUS, &dllrdy);