| Message ID | 1466518157-27140-1-git-send-email-den@openvz.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 06/21/2016 08:09 AM, Denis V. Lunev wrote: > trace_mirror_yield_in_flight accepts 2nd arguments in sectors while here > we pass chunks instead. > > Signed-off-by: Denis V. Lunev <den@openvz.org> > CC: Jeff Cody <jcody@redhat.com> > CC: Kevin Wolf <kwolf@redhat.com> > CC: Max Reitz <mreitz@redhat.com> > --- > Changes from v1: > - proper persons added to CC list > > block/mirror.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/mirror.c b/block/mirror.c > index a04ed9c..930ac96 100644 > --- a/block/mirror.c > +++ b/block/mirror.c > @@ -327,7 +327,7 @@ static uint64_t coroutine_fn mirror_iteration(MirrorBlockJob *s) > > first_chunk = sector_num / sectors_per_chunk; > while (test_bit(first_chunk, s->in_flight_bitmap)) { > - trace_mirror_yield_in_flight(s, first_chunk, s->in_flight); > + trace_mirror_yield_in_flight(s, sector_num, s->in_flight); Ultimately, it would be nice to fix the trace to use bytes instead of sectors. But as a stopgap, this is obviously correct, so: Reviewed-by: Eric Blake <eblake@redhat.com>
On Tue, Jun 21, 2016 at 05:09:17PM +0300, Denis V. Lunev wrote: > trace_mirror_yield_in_flight accepts 2nd arguments in sectors while here > we pass chunks instead. > > Signed-off-by: Denis V. Lunev <den@openvz.org> > CC: Jeff Cody <jcody@redhat.com> > CC: Kevin Wolf <kwolf@redhat.com> > CC: Max Reitz <mreitz@redhat.com> > --- > Changes from v1: > - proper persons added to CC list > > block/mirror.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/mirror.c b/block/mirror.c > index a04ed9c..930ac96 100644 > --- a/block/mirror.c > +++ b/block/mirror.c > @@ -327,7 +327,7 @@ static uint64_t coroutine_fn mirror_iteration(MirrorBlockJob *s) > > first_chunk = sector_num / sectors_per_chunk; > while (test_bit(first_chunk, s->in_flight_bitmap)) { > - trace_mirror_yield_in_flight(s, first_chunk, s->in_flight); > + trace_mirror_yield_in_flight(s, sector_num, s->in_flight); > mirror_wait_for_io(s); > } > > -- > 2.5.0 > Thanks, Applied to my block branch: git://github.com/codyprime/qemu-kvm-jtc.git block -Jeff
diff --git a/block/mirror.c b/block/mirror.c index a04ed9c..930ac96 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -327,7 +327,7 @@ static uint64_t coroutine_fn mirror_iteration(MirrorBlockJob *s) first_chunk = sector_num / sectors_per_chunk; while (test_bit(first_chunk, s->in_flight_bitmap)) { - trace_mirror_yield_in_flight(s, first_chunk, s->in_flight); + trace_mirror_yield_in_flight(s, sector_num, s->in_flight); mirror_wait_for_io(s); }
trace_mirror_yield_in_flight accepts 2nd arguments in sectors while here we pass chunks instead. Signed-off-by: Denis V. Lunev <den@openvz.org> CC: Jeff Cody <jcody@redhat.com> CC: Kevin Wolf <kwolf@redhat.com> CC: Max Reitz <mreitz@redhat.com> --- Changes from v1: - proper persons added to CC list block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)