| Message ID | 1466621761-7283-1-git-send-email-arvind.yadav.cs@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Rafael Wysocki |
| Headers | show |
On Thursday, June 23, 2016 12:26:01 AM Arvind Yadav wrote: > The inline acpi_video_register stub simply allows compilation on systems > with CONFIG_ACPI_VIDEO disabled. the dummy acpi_video_register does not > register an acpi_bus_driver at all. The inline acpi_video_register should > return to indicate lack of support when attempting to register an > acpi_bus_driver on such a system with CONFIG_ACPI_VIDEO disabled. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > include/acpi/video.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/acpi/video.h b/include/acpi/video.h > index 5731ccb..4536bd3 100644 > --- a/include/acpi/video.h > +++ b/include/acpi/video.h > @@ -54,7 +54,7 @@ extern int acpi_video_get_levels(struct acpi_device *device, > struct acpi_video_device_brightness **dev_br, > int *pmax_level); > #else > -static inline int acpi_video_register(void) { return 0; } > +static inline int acpi_video_register(void) { return -ENODEV; } > static inline void acpi_video_unregister(void) { return; } > static inline int acpi_video_get_edid(struct acpi_device *device, int type, > int device_id, void **edid) Aaron, what do you think? -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/23/2016 05:05 AM, Rafael J. Wysocki wrote: > On Thursday, June 23, 2016 12:26:01 AM Arvind Yadav wrote: >> The inline acpi_video_register stub simply allows compilation on systems >> with CONFIG_ACPI_VIDEO disabled. the dummy acpi_video_register does not >> register an acpi_bus_driver at all. The inline acpi_video_register should >> return to indicate lack of support when attempting to register an >> acpi_bus_driver on such a system with CONFIG_ACPI_VIDEO disabled. >> >> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> >> --- >> include/acpi/video.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/acpi/video.h b/include/acpi/video.h >> index 5731ccb..4536bd3 100644 >> --- a/include/acpi/video.h >> +++ b/include/acpi/video.h >> @@ -54,7 +54,7 @@ extern int acpi_video_get_levels(struct acpi_device *device, >> struct acpi_video_device_brightness **dev_br, >> int *pmax_level); >> #else >> -static inline int acpi_video_register(void) { return 0; } >> +static inline int acpi_video_register(void) { return -ENODEV; } >> static inline void acpi_video_unregister(void) { return; } >> static inline int acpi_video_get_edid(struct acpi_device *device, int type, >> int device_id, void **edid) > > Aaron, what do you think? The only place that cares about the return value of acpi_video_register is in acpi_video_init where CONFIG_ACPI_VIDEO must be defined, all other places do not care about the return value so this change shouldn't cause any problems and returning -ENODEV sounds more reasonable than 0 here. Reviewed-by: Aaron Lu <aaron.lu@intel.com> Regards, Aaron -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday, June 23, 2016 09:35:01 AM Aaron Lu wrote: > On 06/23/2016 05:05 AM, Rafael J. Wysocki wrote: > > On Thursday, June 23, 2016 12:26:01 AM Arvind Yadav wrote: > >> The inline acpi_video_register stub simply allows compilation on systems > >> with CONFIG_ACPI_VIDEO disabled. the dummy acpi_video_register does not > >> register an acpi_bus_driver at all. The inline acpi_video_register should > >> return to indicate lack of support when attempting to register an > >> acpi_bus_driver on such a system with CONFIG_ACPI_VIDEO disabled. > >> > >> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > >> --- > >> include/acpi/video.h | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/include/acpi/video.h b/include/acpi/video.h > >> index 5731ccb..4536bd3 100644 > >> --- a/include/acpi/video.h > >> +++ b/include/acpi/video.h > >> @@ -54,7 +54,7 @@ extern int acpi_video_get_levels(struct acpi_device *device, > >> struct acpi_video_device_brightness **dev_br, > >> int *pmax_level); > >> #else > >> -static inline int acpi_video_register(void) { return 0; } > >> +static inline int acpi_video_register(void) { return -ENODEV; } > >> static inline void acpi_video_unregister(void) { return; } > >> static inline int acpi_video_get_edid(struct acpi_device *device, int type, > >> int device_id, void **edid) > > > > Aaron, what do you think? > > The only place that cares about the return value of acpi_video_register > is in acpi_video_init where CONFIG_ACPI_VIDEO must be defined, all other > places do not care about the return value so this change shouldn't cause > any problems and returning -ENODEV sounds more reasonable than 0 here. > > Reviewed-by: Aaron Lu <aaron.lu@intel.com> Patch applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/acpi/video.h b/include/acpi/video.h index 5731ccb..4536bd3 100644 --- a/include/acpi/video.h +++ b/include/acpi/video.h @@ -54,7 +54,7 @@ extern int acpi_video_get_levels(struct acpi_device *device, struct acpi_video_device_brightness **dev_br, int *pmax_level); #else -static inline int acpi_video_register(void) { return 0; } +static inline int acpi_video_register(void) { return -ENODEV; } static inline void acpi_video_unregister(void) { return; } static inline int acpi_video_get_edid(struct acpi_device *device, int type, int device_id, void **edid)
The inline acpi_video_register stub simply allows compilation on systems with CONFIG_ACPI_VIDEO disabled. the dummy acpi_video_register does not register an acpi_bus_driver at all. The inline acpi_video_register should return to indicate lack of support when attempting to register an acpi_bus_driver on such a system with CONFIG_ACPI_VIDEO disabled. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- include/acpi/video.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)