btrfs-progs: tests: 001-simple-unmounted: fix test failure due to bashism
diff mbox

Message ID 20160624234729.GA29145@charon
State Accepted
Headers show

Commit Message

henrix@camandro.org June 24, 2016, 11:47 p.m. UTC
The usage of 'source' is a bashism, and '.' should be used instead.  This
is causing fuzz-tests/001-simple-unmounted to fail in systems where
/bin/sh isn't bash:

    [TEST/fuzz]   001-simple-unmounted
./test.sh: 5: ./test.sh: source: not found
./test.sh: 7: ./test.sh: setup_root_helper: not found
./test.sh: 8: ./test.sh: check_prereq: not found
./test.sh: 18: ./test.sh: check_all_images: not found

Since most (all?) tests actually use /bin/bash, change this test to use
bash too.

Signed-off-by: Luis Henriques <henrix@camandro.org>
---
 tests/fuzz-tests/001-simple-unmounted/test.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Sterba July 4, 2016, 11:37 a.m. UTC | #1
On Sat, Jun 25, 2016 at 12:47:29AM +0100, Luis Henriques wrote:
> The usage of 'source' is a bashism, and '.' should be used instead.  This
> is causing fuzz-tests/001-simple-unmounted to fail in systems where
> /bin/sh isn't bash:
> 
>     [TEST/fuzz]   001-simple-unmounted
> ./test.sh: 5: ./test.sh: source: not found
> ./test.sh: 7: ./test.sh: setup_root_helper: not found
> ./test.sh: 8: ./test.sh: check_prereq: not found
> ./test.sh: 18: ./test.sh: check_all_images: not found
> 
> Since most (all?) tests actually use /bin/bash, change this test to use
> bash too.
> 
> Signed-off-by: Luis Henriques <henrix@camandro.org>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/tests/fuzz-tests/001-simple-unmounted/test.sh b/tests/fuzz-tests/001-simple-unmounted/test.sh
index bf01a3a45a96..98fe7b0ccb74 100755
--- a/tests/fuzz-tests/001-simple-unmounted/test.sh
+++ b/tests/fuzz-tests/001-simple-unmounted/test.sh
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 
 # iterate over all fuzzed images and run 'btrfs check'