powerpc/kernel: Disable the latent entropy plugin unconditionally
diff mbox

Message ID 20160626173451.c8406cd0c7a87cc3f94d9753@gmail.com
State New
Headers show

Commit Message

Emese Revfy June 26, 2016, 3:34 p.m. UTC
Reported-by: PaX Team <pageexec@freemail.hu>
Signed-off-by: Emese Revfy <re.emese@gmail.com>
---
 arch/powerpc/kernel/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Kees Cook June 27, 2016, 4:05 p.m. UTC | #1
On Sun, Jun 26, 2016 at 8:34 AM, Emese Revfy <re.emese@gmail.com> wrote:
>
> Reported-by: PaX Team <pageexec@freemail.hu>
> Signed-off-by: Emese Revfy <re.emese@gmail.com>

Thanks! Can you include a body in the commit message? For this, something like:

Disable the gcc-plugin unconditionlly here because ... *reason it is required*

etc

-Kees

> ---
>  arch/powerpc/kernel/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile
> index 01935b8..e9ef44f 100644
> --- a/arch/powerpc/kernel/Makefile
> +++ b/arch/powerpc/kernel/Makefile
> @@ -14,11 +14,12 @@ CFLAGS_prom_init.o      += -fPIC
>  CFLAGS_btext.o         += -fPIC
>  endif
>
> -ifdef CONFIG_FUNCTION_TRACER
>  CFLAGS_cputable.o += $(DISABLE_LATENT_ENTROPY_PLUGIN)
>  CFLAGS_init.o += $(DISABLE_LATENT_ENTROPY_PLUGIN)
>  CFLAGS_btext.o += $(DISABLE_LATENT_ENTROPY_PLUGIN)
>  CFLAGS_prom.o += $(DISABLE_LATENT_ENTROPY_PLUGIN)
> +
> +ifdef CONFIG_FUNCTION_TRACER
>  # Do not trace early boot code
>  CFLAGS_REMOVE_cputable.o = -mno-sched-epilog $(CC_FLAGS_FTRACE)
>  CFLAGS_REMOVE_prom_init.o = -mno-sched-epilog $(CC_FLAGS_FTRACE)
> --
> 2.8.1
Emese Revfy June 28, 2016, 11:39 a.m. UTC | #2
On Mon, 27 Jun 2016 09:05:08 -0700
Kees Cook <keescook@chromium.org> wrote:

> On Sun, Jun 26, 2016 at 8:34 AM, Emese Revfy <re.emese@gmail.com> wrote:
> >
> > Reported-by: PaX Team <pageexec@freemail.hu>
> > Signed-off-by: Emese Revfy <re.emese@gmail.com>
> 
> Thanks! Can you include a body in the commit message? For this, something like:
> 
> Disable the gcc-plugin unconditionlly here because ... *reason it is required*

Hi,

You can see it here:
https://github.com/ephox-gcc-plugins/gcc-plugins_linux-next/commit/a1bb2bd3fd9ac414623ec3210e9c514d9d38cf9e
Kees Cook July 6, 2016, 6:57 p.m. UTC | #3
On Tue, Jun 28, 2016 at 7:39 AM, Emese Revfy <re.emese@gmail.com> wrote:
> On Mon, 27 Jun 2016 09:05:08 -0700
> Kees Cook <keescook@chromium.org> wrote:
>
>> On Sun, Jun 26, 2016 at 8:34 AM, Emese Revfy <re.emese@gmail.com> wrote:
>> >
>> > Reported-by: PaX Team <pageexec@freemail.hu>
>> > Signed-off-by: Emese Revfy <re.emese@gmail.com>
>>
>> Thanks! Can you include a body in the commit message? For this, something like:
>>
>> Disable the gcc-plugin unconditionlly here because ... *reason it is required*
>
> Hi,
>
> You can see it here:
> https://github.com/ephox-gcc-plugins/gcc-plugins_linux-next/commit/a1bb2bd3fd9ac414623ec3210e9c514d9d38cf9e

Thanks, I've squashed this into the latenty_entropy initial commit in my tree.

-Kees

>
> --
> Emese
Andrew Donnellan Nov. 2, 2016, 5:06 a.m. UTC | #4
On 27/06/16 01:34, Emese Revfy wrote:
>
> Reported-by: PaX Team <pageexec@freemail.hu>
> Signed-off-by: Emese Revfy <re.emese@gmail.com>
> ---
>  arch/powerpc/kernel/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile
> index 01935b8..e9ef44f 100644
> --- a/arch/powerpc/kernel/Makefile
> +++ b/arch/powerpc/kernel/Makefile
> @@ -14,11 +14,12 @@ CFLAGS_prom_init.o      += -fPIC
>  CFLAGS_btext.o         += -fPIC
>  endif
>
> -ifdef CONFIG_FUNCTION_TRACER
>  CFLAGS_cputable.o += $(DISABLE_LATENT_ENTROPY_PLUGIN)
>  CFLAGS_init.o += $(DISABLE_LATENT_ENTROPY_PLUGIN)

I think you meant prom_init.o...

Additionally, DISABLE_LATENT_ENTROPY_PLUGIN is conditioned on 
CONFIG_PAX_LATENT_ENTROPY rather than CONFIG_GCC_PLUGIN_LATENT_ENTROPY, 
so it doesn't get exported correctly.

Will submit fixes along with patches to enable plugins on powerpc once I 
get that sorted.

(In future please remember to cc linuxppc-dev.)
Kees Cook Nov. 15, 2016, 10:41 p.m. UTC | #5
On Tue, Nov 1, 2016 at 10:06 PM, Andrew Donnellan
<andrew.donnellan@au1.ibm.com> wrote:
> On 27/06/16 01:34, Emese Revfy wrote:
>>
>>
>> Reported-by: PaX Team <pageexec@freemail.hu>
>> Signed-off-by: Emese Revfy <re.emese@gmail.com>
>> ---
>>  arch/powerpc/kernel/Makefile | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile
>> index 01935b8..e9ef44f 100644
>> --- a/arch/powerpc/kernel/Makefile
>> +++ b/arch/powerpc/kernel/Makefile
>> @@ -14,11 +14,12 @@ CFLAGS_prom_init.o      += -fPIC
>>  CFLAGS_btext.o         += -fPIC
>>  endif
>>
>> -ifdef CONFIG_FUNCTION_TRACER
>>  CFLAGS_cputable.o += $(DISABLE_LATENT_ENTROPY_PLUGIN)
>>  CFLAGS_init.o += $(DISABLE_LATENT_ENTROPY_PLUGIN)
>
>
> I think you meant prom_init.o...
>
> Additionally, DISABLE_LATENT_ENTROPY_PLUGIN is conditioned on
> CONFIG_PAX_LATENT_ENTROPY rather than CONFIG_GCC_PLUGIN_LATENT_ENTROPY, so
> it doesn't get exported correctly.
>
> Will submit fixes along with patches to enable plugins on powerpc once I get
> that sorted.
>
> (In future please remember to cc linuxppc-dev.)

Just checking in: did these patches materialize? I'd love to see
plugins working on v4.10 for ppc.

-Kees
Andrew Donnellan Nov. 15, 2016, 10:45 p.m. UTC | #6
On 16/11/16 09:41, Kees Cook wrote:
> Just checking in: did these patches materialize? I'd love to see
> plugins working on v4.10 for ppc.

Working on it! 
https://github.com/ajdlinux/linux/tree/powerpc-gcc-plugin-infrastructure

Just need to test with all the compilers to figure out which ones are 
broken so we can put a version check in...
Kees Cook Nov. 15, 2016, 11:06 p.m. UTC | #7
On Tue, Nov 15, 2016 at 2:45 PM, Andrew Donnellan
<andrew.donnellan@au1.ibm.com> wrote:
> On 16/11/16 09:41, Kees Cook wrote:
>>
>> Just checking in: did these patches materialize? I'd love to see
>> plugins working on v4.10 for ppc.
>
>
> Working on it!
> https://github.com/ajdlinux/linux/tree/powerpc-gcc-plugin-infrastructure

Very cool, thanks!

> Just need to test with all the compilers to figure out which ones are broken
> so we can put a version check in...

Sounds good.

-Kees

Patch
diff mbox

diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile
index 01935b8..e9ef44f 100644
--- a/arch/powerpc/kernel/Makefile
+++ b/arch/powerpc/kernel/Makefile
@@ -14,11 +14,12 @@  CFLAGS_prom_init.o      += -fPIC
 CFLAGS_btext.o         += -fPIC
 endif
 
-ifdef CONFIG_FUNCTION_TRACER
 CFLAGS_cputable.o += $(DISABLE_LATENT_ENTROPY_PLUGIN)
 CFLAGS_init.o += $(DISABLE_LATENT_ENTROPY_PLUGIN)
 CFLAGS_btext.o += $(DISABLE_LATENT_ENTROPY_PLUGIN)
 CFLAGS_prom.o += $(DISABLE_LATENT_ENTROPY_PLUGIN)
+
+ifdef CONFIG_FUNCTION_TRACER
 # Do not trace early boot code
 CFLAGS_REMOVE_cputable.o = -mno-sched-epilog $(CC_FLAGS_FTRACE)
 CFLAGS_REMOVE_prom_init.o = -mno-sched-epilog $(CC_FLAGS_FTRACE)