diff mbox

ALSA: hda/realtek - add new pin definition in alc225 pin quirk table

Message ID 1467776966-24215-1-git-send-email-hui.wang@canonical.com (mailing list archive)
State New, archived
Headers show

Commit Message

Hui Wang July 6, 2016, 3:49 a.m. UTC
We have some Dell laptops which can't detect headset mic, the machines
use the codec ALC225, they have some new pin configuration values,
after adding them in the alc225 pin quirk table, they work well.

Cc: <stable@vger.kernel.org>
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

Comments

Hui Wang July 7, 2016, 2:32 a.m. UTC | #1
Please skip this patch, we have more pins to add into this pin quirk 
table (for new machines).

On 07/06/2016 11:49 AM, Hui Wang wrote:
> We have some Dell laptops which can't detect headset mic, the machines
> use the codec ALC225, they have some new pin configuration values,
> after adding them in the alc225 pin quirk table, they work well.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> ---
>   sound/pci/hda/patch_realtek.c | 11 ++++++++++-
>   1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 45d4dc1..e25ef2b 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5753,7 +5753,6 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
>   	{}
>   };
>   #define ALC225_STANDARD_PINS \
> -	{0x12, 0xb7a60130}, \
>   	{0x21, 0x04211020}
>   
>   #define ALC256_STANDARD_PINS \
> @@ -5778,9 +5777,19 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
>   static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
>   	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
>   		ALC225_STANDARD_PINS,
> +		{0x12, 0xb7a60130},
>   		{0x14, 0x901701a0}),
>   	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
>   		ALC225_STANDARD_PINS,
> +		{0x12, 0xb7a60130},
> +		{0x14, 0x901701b0}),
> +	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
> +		ALC225_STANDARD_PINS,
> +		{0x12, 0xb7a60150},
> +		{0x14, 0x901701a0}),
> +	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
> +		ALC225_STANDARD_PINS,
> +		{0x12, 0xb7a60150},
>   		{0x14, 0x901701b0}),
>   	SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE,
>   		{0x14, 0x90170110},
Takashi Iwai July 7, 2016, 5:35 a.m. UTC | #2
On Thu, 07 Jul 2016 04:32:44 +0200,
Hui Wang wrote:
> 
> Please skip this patch, we have more pins to add into this pin quirk
> table (for new machines).

OK.


thanks,

Takashi

> On 07/06/2016 11:49 AM, Hui Wang wrote:
> > We have some Dell laptops which can't detect headset mic, the machines
> > use the codec ALC225, they have some new pin configuration values,
> > after adding them in the alc225 pin quirk table, they work well.
> >
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Hui Wang <hui.wang@canonical.com>
> > ---
> >   sound/pci/hda/patch_realtek.c | 11 ++++++++++-
> >   1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> > index 45d4dc1..e25ef2b 100644
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -5753,7 +5753,6 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
> >   	{}
> >   };
> >   #define ALC225_STANDARD_PINS \
> > -	{0x12, 0xb7a60130}, \
> >   	{0x21, 0x04211020}
> >     #define ALC256_STANDARD_PINS \
> > @@ -5778,9 +5777,19 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
> >   static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
> >   	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
> >   		ALC225_STANDARD_PINS,
> > +		{0x12, 0xb7a60130},
> >   		{0x14, 0x901701a0}),
> >   	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
> >   		ALC225_STANDARD_PINS,
> > +		{0x12, 0xb7a60130},
> > +		{0x14, 0x901701b0}),
> > +	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
> > +		ALC225_STANDARD_PINS,
> > +		{0x12, 0xb7a60150},
> > +		{0x14, 0x901701a0}),
> > +	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
> > +		ALC225_STANDARD_PINS,
> > +		{0x12, 0xb7a60150},
> >   		{0x14, 0x901701b0}),
> >   	SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE,
> >   		{0x14, 0x90170110},
>
diff mbox

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 45d4dc1..e25ef2b 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5753,7 +5753,6 @@  static const struct hda_model_fixup alc269_fixup_models[] = {
 	{}
 };
 #define ALC225_STANDARD_PINS \
-	{0x12, 0xb7a60130}, \
 	{0x21, 0x04211020}
 
 #define ALC256_STANDARD_PINS \
@@ -5778,9 +5777,19 @@  static const struct hda_model_fixup alc269_fixup_models[] = {
 static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
 	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
 		ALC225_STANDARD_PINS,
+		{0x12, 0xb7a60130},
 		{0x14, 0x901701a0}),
 	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
 		ALC225_STANDARD_PINS,
+		{0x12, 0xb7a60130},
+		{0x14, 0x901701b0}),
+	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
+		ALC225_STANDARD_PINS,
+		{0x12, 0xb7a60150},
+		{0x14, 0x901701a0}),
+	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
+		ALC225_STANDARD_PINS,
+		{0x12, 0xb7a60150},
 		{0x14, 0x901701b0}),
 	SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE,
 		{0x14, 0x90170110},