From patchwork Wed Jul 6 12:15:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: weiyj_lk@163.com X-Patchwork-Id: 9216271 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9DB4660752 for ; Wed, 6 Jul 2016 12:16:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8E08328880 for ; Wed, 6 Jul 2016 12:16:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 81DA428882; Wed, 6 Jul 2016 12:16:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2F51628880 for ; Wed, 6 Jul 2016 12:16:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753919AbcGFMQn (ORCPT ); Wed, 6 Jul 2016 08:16:43 -0400 Received: from m12-14.163.com ([220.181.12.14]:38795 "EHLO m12-14.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753703AbcGFMQn (ORCPT ); Wed, 6 Jul 2016 08:16:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=u7dst WtxSOGHPTGyX+bO4XczE4/NLCpPQeJooQ0pwqM=; b=AXyreHNguRg5k0pMx8iP1 vSt8dNlBeguKpFPSOdiIXwUH7uiM5SnkCvUk1cVXTIKCCOlpcmstoqPZma1c0JtS HbwErt6LoZUihbEqHi6/94nZTxyHd9b+hF+DZy5FodkCOat9cyks2yNCU19mPnVS YYDhqZdRkq1X7YLrUapg80= Received: from localhost.localdomain.localdomain (unknown [49.77.207.185]) by smtp10 (Coremail) with SMTP id DsCowACH62R69nxXtVY7Cg--.63708S2; Wed, 06 Jul 2016 20:15:56 +0800 (CST) From: weiyj_lk@163.com To: Marek Szyprowski , Joerg Roedel , Kukjin Kim , Krzysztof Kozlowski Cc: Wei Yongjun , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH -next] iommu/exynos: Fix return value check in exynos_iommu_of_setup() Date: Wed, 6 Jul 2016 12:15:54 +0000 Message-Id: <1467807354-26503-1-git-send-email-weiyj_lk@163.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-CM-TRANSID: DsCowACH62R69nxXtVY7Cg--.63708S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7Wr4kGry8KrW7GFy8KF1UAwb_yoWfZFbEkF 1rZwnrXr4Y9r4qvF4jgr43Zr9Iyas3ursxWFWIg343JryDXrn3trW8ZryIyFWxWr4vyFZx trnxCr1fAry7KjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUnJfHUUUUUU== X-Originating-IP: [49.77.207.185] X-CM-SenderInfo: pzhl5yxbonqiywtou0bp/xtbBDRye1laDn7R3VgAAsG Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun In case of error, the function of_platform_device_create() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Signed-off-by: Wei Yongjun Reviewed-by: Dennis Chen Reviewed-by: Krzysztof Kozlowski Acked-by: Marek Szyprowski --- drivers/iommu/exynos-iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index 33dcc29..9b23059 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c @@ -1345,8 +1345,8 @@ static int __init exynos_iommu_of_setup(struct device_node *np) exynos_iommu_init(); pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root); - if (IS_ERR(pdev)) - return PTR_ERR(pdev); + if (!pdev) + return -ENOMEM; /* * use the first registered sysmmu device for performing