| Message ID | 20160707094952.4111577-2-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jul 07, 2016 at 11:49:46AM +0200, Arnd Bergmann wrote: > This documents the binding used by Alexander Shiyan's DT support for > the clps711x SPI controller. > > I've left the file name to match the ARM platform port name "clps711x" > for consistency with the other bindings, even though the compatible > string refers to the later ep7309 chip. > > Linux no longer supports the old clps711x and ep72xx product lines, > but we still use the name. The entire family is now discontinued > by the manufacturer. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Cc: Alexander Shiyan <shc_work@mail.ru> > --- > .../devicetree/bindings/spi/spi-clps711x.txt | 33 ++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/spi-clps711x.txt > > diff --git a/Documentation/devicetree/bindings/spi/spi-clps711x.txt b/Documentation/devicetree/bindings/spi/spi-clps711x.txt > new file mode 100644 > index 000000000000..4c3ec13f423f > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/spi-clps711x.txt > @@ -0,0 +1,33 @@ > +Serial Peripheral Interface on Cirrus Logic CL-PS71xx, EP72xx, EP73xx > + > +Required properties > +- #address-cells: must be <1> > +- #size-cells: must be <0> > +- compatible: should include "cirrus,ep7209-spi" > +- reg: Address and length of one register range > +- interrupts: one interrupt line > +- clocks: One entry, refers to the SPI bus clock > +- cs-gpios: Specifies the gpio pins to be used for chipselects. > + See: Documentation/devicetree/bindings/spi/spi-bus.txt > + > +An additional register is present in the system controller, > +which is assumed to be in the same device tree, with and marked > +as compatible with "cirrus,ep7209-syscon3". > + > +Example: > + > +spi@80000500 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "cirrus,ep7209-spi"; > + reg = <0x80000500 0x4>; > + interrupts = <15>; > + clocks = <&clks CLPS711X_CLK_SPI>; > + status = "disabled"; > +}; > + > +syscon3: syscon@80002200 { This looks like it shouldn't be here. > + compatible = "cirrus,ep7209-syscon3", "syscon"; > + reg = <0x80002200 0x40>; > +}; > + > -- > 2.9.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday, July 12, 2016 3:49:47 PM CEST Rob Herring wrote: > On Thu, Jul 07, 2016 at 11:49:46AM +0200, Arnd Bergmann wrote: > > + > > +An additional register is present in the system controller, > > +which is assumed to be in the same device tree, with and marked > > +as compatible with "cirrus,ep7209-syscon3". > > + > > +Example: > > + > > +spi@80000500 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + compatible = "cirrus,ep7209-spi"; > > + reg = <0x80000500 0x4>; > > + interrupts = <15>; > > + clocks = <&clks CLPS711X_CLK_SPI>; > > + status = "disabled"; > > +}; > > + > > +syscon3: syscon@80002200 { > > This looks like it shouldn't be here. The label, or the entire node? Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
>Среда, 13 июля 2016, 11:13 +03:00 от Arnd Bergmann <arnd@arndb.de>: > >On Tuesday, July 12, 2016 3:49:47 PM CEST Rob Herring wrote: >> On Thu, Jul 07, 2016 at 11:49:46AM +0200, Arnd Bergmann wrote: >> > + >> > +An additional register is present in the system controller, >> > +which is assumed to be in the same device tree, with and marked >> > +as compatible with "cirrus,ep7209-syscon3". >> > + >> > +Example: >> > + >> > +spi@80000500 { >> > + #address-cells = <1>; >> > + #size-cells = <0>; >> > + compatible = "cirrus,ep7209-spi"; >> > + reg = <0x80000500 0x4>; >> > + interrupts = <15>; >> > + clocks = <&clks CLPS711X_CLK_SPI>; >> > + status = "disabled"; >> > +}; >> > + >> > +syscon3: syscon@80002200 { >> >> This looks like it shouldn't be here. > >The label, or the entire node? I think that the whole syscon3 node is redundant. ---
On Wednesday, July 13, 2016 11:20:00 AM CEST Alexander Shiyan wrote: > >Среда, 13 июля 2016, 11:13 +03:00 от Arnd Bergmann <arnd@arndb.de>: > > > >On Tuesday, July 12, 2016 3:49:47 PM CEST Rob Herring wrote: > >> On Thu, Jul 07, 2016 at 11:49:46AM +0200, Arnd Bergmann wrote: > >> > + > >> > +An additional register is present in the system controller, > >> > +which is assumed to be in the same device tree, with and marked > >> > +as compatible with "cirrus,ep7209-syscon3". > >> > + > >> > +Example: > >> > + > >> > +spi@80000500 { > >> > + #address-cells = <1>; > >> > + #size-cells = <0>; > >> > + compatible = "cirrus,ep7209-spi"; > >> > + reg = <0x80000500 0x4>; > >> > + interrupts = <15>; > >> > + clocks = <&clks CLPS711X_CLK_SPI>; > >> > + status = "disabled"; > >> > +}; > >> > + > >> > +syscon3: syscon@80002200 { > >> > >> This looks like it shouldn't be here. > > > >The label, or the entire node? > > I think that the whole syscon3 node is redundant. The node is needed here because it is required for the device to work: the binding doesn't contain a label for the syscon reference but as I documented above, any driver will have to look up the syscon by compatible string. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/spi/spi-clps711x.txt b/Documentation/devicetree/bindings/spi/spi-clps711x.txt new file mode 100644 index 000000000000..4c3ec13f423f --- /dev/null +++ b/Documentation/devicetree/bindings/spi/spi-clps711x.txt @@ -0,0 +1,33 @@ +Serial Peripheral Interface on Cirrus Logic CL-PS71xx, EP72xx, EP73xx + +Required properties +- #address-cells: must be <1> +- #size-cells: must be <0> +- compatible: should include "cirrus,ep7209-spi" +- reg: Address and length of one register range +- interrupts: one interrupt line +- clocks: One entry, refers to the SPI bus clock +- cs-gpios: Specifies the gpio pins to be used for chipselects. + See: Documentation/devicetree/bindings/spi/spi-bus.txt + +An additional register is present in the system controller, +which is assumed to be in the same device tree, with and marked +as compatible with "cirrus,ep7209-syscon3". + +Example: + +spi@80000500 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "cirrus,ep7209-spi"; + reg = <0x80000500 0x4>; + interrupts = <15>; + clocks = <&clks CLPS711X_CLK_SPI>; + status = "disabled"; +}; + +syscon3: syscon@80002200 { + compatible = "cirrus,ep7209-syscon3", "syscon"; + reg = <0x80002200 0x40>; +}; +
This documents the binding used by Alexander Shiyan's DT support for the clps711x SPI controller. I've left the file name to match the ARM platform port name "clps711x" for consistency with the other bindings, even though the compatible string refers to the later ep7309 chip. Linux no longer supports the old clps711x and ep72xx product lines, but we still use the name. The entire family is now discontinued by the manufacturer. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Alexander Shiyan <shc_work@mail.ru> --- .../devicetree/bindings/spi/spi-clps711x.txt | 33 ++++++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/spi-clps711x.txt