diff mbox

multipath-tools: add template to add new hardware

Message ID 1468334507-7531-1-git-send-email-xose.vazquez@gmail.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Xose Vazquez Perez July 12, 2016, 2:41 p.m. UTC
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

Comments

Christophe Varoqui July 22, 2016, 9:50 a.m. UTC | #1
Merged.
Thanks.

On Tue, Jul 12, 2016 at 4:41 PM, Xose Vazquez Perez <xose.vazquez@gmail.com>
wrote:

> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
>  libmultipath/hwtable.c | 42 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index 5b896ee..a1fc3e8 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -16,6 +16,8 @@
>   * family. Please mail the currently enlisted maintainer and
>   * the upstream package maintainer.
>   *
> + * Please, use the TEMPLATE below to add new hardware.
> + *
>   * WARNING:
>   *
>   * Devices with a proprietary handler must also be included in
> @@ -756,6 +758,46 @@ static struct hwentry default_hw[] = {
>                 .pgfailback    = 30,
>                 .minio         = 128,
>         },
> +#if 0
> +       /*
> +        * Copy this TEMPLATE to add new hardware.
> +        *
> +        * Keep only mandatory and modified attributes.
> +        * Standard attributes must be removed.
> +        *
> +        * COMPANY_NAME
> +        *
> +        * Maintainer : XXX
> +        * Mail : XXX
> +        */
> +       {
> +               .vendor        = "VENDOR", (Mandatory)
> +               .product       = "PRODUCT", (Mandatory)
> +               .revision      = "REVISION",
> +               .bl_product    = "BL_PRODUCT",
> +               .pgpolicy      = GROUP_BY_PRIO,
> +               .uid_attribute = "ID_SERIAL",
> +               .selector      = "service-time 0",
> +               .checker_name  = TUR,
> +               .features      = "0",
> +               .hwhandler     = "0",
> +               .prio_name     = "const",
> +               .prio_args     = "",
> +               .pgfailback    = -FAILBACK_IMMEDIATE,
> +               .rr_weight     = RR_WEIGHT_NONE,
> +               .no_path_retry = NO_PATH_RETRY_UNDEF,
> +               .minio         = 1000,
> +               .minio_rq      = 1,
> +               .flush_on_last_del = FLUSH_DISABLED,
> +               .fast_io_fail  = 5,
> +               .dev_loss      = 600,
> +               .retain_hwhandler = RETAIN_HWHANDLER_ON,
> +               .detect_prio   = DETECT_PRIO_ON,
> +               .deferred_remove = DEFERRED_REMOVE_OFF,
> +               .delay_watch_checks = DELAY_CHECKS_OFF,
> +               .delay_wait_checks = DELAY_CHECKS_OFF,
> +       },
> +#endif
>         /*
>          * EOL
>          */
> --
> 2.7.4
>
>
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Xose Vazquez Perez Aug. 2, 2016, 8:34 p.m. UTC | #2
On 07/12/2016 04:41 PM, Xose Vazquez Perez wrote:

> +	/*
> +	 * Copy this TEMPLATE to add new hardware.
> +	 *
> +	 * Keep only mandatory and modified attributes.
> +	 * Standard attributes must be removed.
> +	 *
> +	 * COMPANY_NAME
> +	 *
> +	 * Maintainer : XXX
> +	 * Mail : XXX
> +	 */
> +	{
> +		.vendor        = "VENDOR", (Mandatory)
> +		.product       = "PRODUCT", (Mandatory)
> +		.revision      = "REVISION",
> +		.bl_product    = "BL_PRODUCT",
> +		.pgpolicy      = GROUP_BY_PRIO,
> +		.uid_attribute = "ID_SERIAL",
> +		.selector      = "service-time 0",
> +		.checker_name  = TUR,
> +		.features      = "0",
> +		.hwhandler     = "0",
> +		.prio_name     = "const",
> +		.prio_args     = "",
> +		.pgfailback    = -FAILBACK_IMMEDIATE,
> +		.rr_weight     = RR_WEIGHT_NONE,
> +		.no_path_retry = NO_PATH_RETRY_UNDEF,
> +		.minio         = 1000,
> +		.minio_rq      = 1,
> +		.flush_on_last_del = FLUSH_DISABLED,
> +		.fast_io_fail  = 5,
> +		.dev_loss      = 600,
> +		.retain_hwhandler = RETAIN_HWHANDLER_ON,
> +		.detect_prio   = DETECT_PRIO_ON,
> +		.deferred_remove = DEFERRED_REMOVE_OFF,
> +		.delay_watch_checks = DELAY_CHECKS_OFF,
> +		.delay_wait_checks = DELAY_CHECKS_OFF,

Note that ".getuid" ".alias_prefix" and ".user_friendly_names" were hidden
consciously from the TEMPLATE.

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
diff mbox

Patch

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 5b896ee..a1fc3e8 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -16,6 +16,8 @@ 
  * family. Please mail the currently enlisted maintainer and
  * the upstream package maintainer.
  *
+ * Please, use the TEMPLATE below to add new hardware.
+ *
  * WARNING:
  *
  * Devices with a proprietary handler must also be included in
@@ -756,6 +758,46 @@  static struct hwentry default_hw[] = {
 		.pgfailback    = 30,
 		.minio         = 128,
 	},
+#if 0
+	/*
+	 * Copy this TEMPLATE to add new hardware.
+	 *
+	 * Keep only mandatory and modified attributes.
+	 * Standard attributes must be removed.
+	 *
+	 * COMPANY_NAME
+	 *
+	 * Maintainer : XXX
+	 * Mail : XXX
+	 */
+	{
+		.vendor        = "VENDOR", (Mandatory)
+		.product       = "PRODUCT", (Mandatory)
+		.revision      = "REVISION",
+		.bl_product    = "BL_PRODUCT",
+		.pgpolicy      = GROUP_BY_PRIO,
+		.uid_attribute = "ID_SERIAL",
+		.selector      = "service-time 0",
+		.checker_name  = TUR,
+		.features      = "0",
+		.hwhandler     = "0",
+		.prio_name     = "const",
+		.prio_args     = "",
+		.pgfailback    = -FAILBACK_IMMEDIATE,
+		.rr_weight     = RR_WEIGHT_NONE,
+		.no_path_retry = NO_PATH_RETRY_UNDEF,
+		.minio         = 1000,
+		.minio_rq      = 1,
+		.flush_on_last_del = FLUSH_DISABLED,
+		.fast_io_fail  = 5,
+		.dev_loss      = 600,
+		.retain_hwhandler = RETAIN_HWHANDLER_ON,
+		.detect_prio   = DETECT_PRIO_ON,
+		.deferred_remove = DEFERRED_REMOVE_OFF,
+		.delay_watch_checks = DELAY_CHECKS_OFF,
+		.delay_wait_checks = DELAY_CHECKS_OFF,
+	},
+#endif
 	/*
 	 * EOL
 	 */