diff mbox

[30/34] alisp: remove alloca() from FA_hctl_find_elem()

Message ID 1468505271-5769-31-git-send-email-o-takashi@sakamocchi.jp (mailing list archive)
State New, archived
Headers show

Commit Message

Takashi Sakamoto July 14, 2016, 2:07 p.m. UTC 
Both of alloca() and automatic variables keeps storages on stack, while
the former generates more instructions than the latter. It's better to use
the latter if the size of storage is computable at pre-compile or compile
time; i.e. just for structures.

This commit obsolete usages of alloca() with automatic variables.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
 src/alisp/alisp_snd.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
diff mbox

Patch

diff --git a/src/alisp/alisp_snd.c b/src/alisp/alisp_snd.c
index e622035..e9c3573 100644
--- a/src/alisp/alisp_snd.c
+++ b/src/alisp/alisp_snd.c
@@ -522,7 +522,7 @@  static int parse_ctl_elem_id(struct alisp_instance * instance,
 static struct alisp_object * FA_hctl_find_elem(struct alisp_instance * instance, struct acall_table * item, struct alisp_object * args)
 {
 	snd_hctl_t *handle;
-	snd_ctl_elem_id_t *id;
+	snd_ctl_elem_id_t id = {0};
 	struct alisp_object *p1;
 
 	handle = (snd_hctl_t *)get_ptr(instance, car(args), item->prefix);
@@ -531,14 +531,13 @@  static struct alisp_object * FA_hctl_find_elem(struct alisp_instance * instance,
 		delete_object(instance, args);
 		return &alsa_lisp_nil;
 	}
-	snd_ctl_elem_id_alloca(&id);
 	p1 = car(cdr(args));
 	delete_tree(instance, cdr(cdr(args)));
 	delete_object(instance, cdr(args));
 	delete_object(instance, args);
-	if (parse_ctl_elem_id(instance, eval(instance, p1), id) < 0)
+	if (parse_ctl_elem_id(instance, eval(instance, p1), &id) < 0)
 		return &alsa_lisp_nil;
-	return new_cons_pointer(instance, "hctl_elem", snd_hctl_find_elem(handle, id));
+	return new_cons_pointer(instance, "hctl_elem", snd_hctl_find_elem(handle, &id));
 }
 
 static struct alisp_object * FA_hctl_elem_info(struct alisp_instance * instance, struct acall_table * item, struct alisp_object * args)