Applied "ASoC: Intel: Fix conflicting pcm dev drvdata on haswell" to the asoc tree
diff mbox

Message ID E1bNjYY-0001TX-7a@debutante
State Not Applicable
Headers show

Commit Message

Mark Brown July 14, 2016, 4:32 p.m. UTC
The patch

   ASoC: Intel: Fix conflicting pcm dev drvdata on haswell

has been applied to the asoc tree at


All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.


From c999675b04c146aa57f6e853a3746de979427fad Mon Sep 17 00:00:00 2001
From: Ben Zhang <>
Date: Thu, 7 Jul 2016 18:54:56 -0700
Subject: [PATCH] ASoC: Intel: Fix conflicting pcm dev drvdata on haswell

soc-core sets the snd_soc_pcm_runtime->dev drvdata to
snd_soc_pcm_runtime in soc_post_component_init, and access
it in places like codec_reg_show.

hsw_pcm_open overwrites the drvdata to point to hsw_pcm_data,
confusing soc-core, and causing crashes when cat
/sys/devices/pci0000:00/INT3438:00/.../System PCM/codec_reg

This patch removes the set in hsw_pcm_open since it's no longer
used. commit 7ff9d6714a5c ("ASoC: Intel: Split hsw_pcm_data for
playback and capture") already removed all calls to

Signed-off-by: Ben Zhang <>
Signed-off-by: Mark Brown <>
 sound/soc/intel/haswell/sst-haswell-pcm.c | 1 -
 1 file changed, 1 deletion(-)

diff mbox

diff --git a/sound/soc/intel/haswell/sst-haswell-pcm.c b/sound/soc/intel/haswell/sst-haswell-pcm.c
index 994256b39b9c..3154525c2b83 100644
--- a/sound/soc/intel/haswell/sst-haswell-pcm.c
+++ b/sound/soc/intel/haswell/sst-haswell-pcm.c
@@ -819,7 +819,6 @@  static int hsw_pcm_open(struct snd_pcm_substream *substream)
-	snd_soc_pcm_set_drvdata(rtd, pcm_data);
 	pcm_data->substream = substream;
 	snd_soc_set_runtime_hwparams(substream, &hsw_pcm_hardware);