| Message ID | 1309251943.3984.1.camel@phoenix (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Axel Lin <axel.lin@gmail.com> writes: > The gpio-omap driver has been converted to use generic IRQ chip. > Thus select GENERIC_IRQ_CHIP for TI OMAP1 to fix below build error. > > LD vmlinux > drivers/built-in.o: In function `omap_mpuio_alloc_gc': > drivers/gpio/gpio-omap.c:1087: undefined reference to `irq_alloc_generic_chip' > drivers/gpio/gpio-omap.c:1100: undefined reference to `irq_setup_generic_chip' > drivers/built-in.o: In function `omap_gpio_show_rev': > drivers/gpio/gpio-omap.c:998: undefined reference to `irq_gc_mask_clr_bit' > drivers/gpio/gpio-omap.c:998: undefined reference to `irq_gc_mask_set_bit' > make: *** [vmlinux] Error 1 > > Signed-off-by: Axel Lin <axel.lin@gmail.com> Thanks, I have a fix for this already queued for v3.0-rc3 series: http://marc.info/?l=linux-omap&m=130749135312468&w=2 Kevin
2011/6/28 Kevin Hilman <khilman@ti.com>: > Axel Lin <axel.lin@gmail.com> writes: > >> The gpio-omap driver has been converted to use generic IRQ chip. >> Thus select GENERIC_IRQ_CHIP for TI OMAP1 to fix below build error. >> >> LD vmlinux >> drivers/built-in.o: In function `omap_mpuio_alloc_gc': >> drivers/gpio/gpio-omap.c:1087: undefined reference to `irq_alloc_generic_chip' >> drivers/gpio/gpio-omap.c:1100: undefined reference to `irq_setup_generic_chip' >> drivers/built-in.o: In function `omap_gpio_show_rev': >> drivers/gpio/gpio-omap.c:998: undefined reference to `irq_gc_mask_clr_bit' >> drivers/gpio/gpio-omap.c:998: undefined reference to `irq_gc_mask_set_bit' >> make: *** [vmlinux] Error 1 >> >> Signed-off-by: Axel Lin <axel.lin@gmail.com> > > Thanks, I have a fix for this already queued for v3.0-rc3 series: > > http://marc.info/?l=linux-omap&m=130749135312468&w=2 > Hi, Seems this patch is not upstream. I still have the same build error with [linux-next: Tree for July 16]. Regards, Axel
Axel Lin <axel.lin@gmail.com> writes: > 2011/6/28 Kevin Hilman <khilman@ti.com>: >> Axel Lin <axel.lin@gmail.com> writes: >> >>> The gpio-omap driver has been converted to use generic IRQ chip. >>> Thus select GENERIC_IRQ_CHIP for TI OMAP1 to fix below build error. >>> >>> LD vmlinux >>> drivers/built-in.o: In function `omap_mpuio_alloc_gc': >>> drivers/gpio/gpio-omap.c:1087: undefined reference to `irq_alloc_generic_chip' >>> drivers/gpio/gpio-omap.c:1100: undefined reference to `irq_setup_generic_chip' >>> drivers/built-in.o: In function `omap_gpio_show_rev': >>> drivers/gpio/gpio-omap.c:998: undefined reference to `irq_gc_mask_clr_bit' >>> drivers/gpio/gpio-omap.c:998: undefined reference to `irq_gc_mask_set_bit' >>> make: *** [vmlinux] Error 1 >>> >>> Signed-off-by: Axel Lin <axel.lin@gmail.com> >> >> Thanks, I have a fix for this already queued for v3.0-rc3 series: >> >> http://marc.info/?l=linux-omap&m=130749135312468&w=2 >> > > Seems this patch is not upstream. > I still have the same build error with [linux-next: Tree for July 16]. Hmm, you're right. Tony hasn't queued that fix yet. Tony? Kevin
diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig index 49a4c75..9a4a6bf 100644 --- a/arch/arm/plat-omap/Kconfig +++ b/arch/arm/plat-omap/Kconfig @@ -13,6 +13,7 @@ config ARCH_OMAP1 bool "TI OMAP1" select CLKDEV_LOOKUP select CLKSRC_MMIO + select GENERIC_IRQ_CHIP help "Systems based on omap7xx, omap15xx or omap16xx"
The gpio-omap driver has been converted to use generic IRQ chip. Thus select GENERIC_IRQ_CHIP for TI OMAP1 to fix below build error. LD vmlinux drivers/built-in.o: In function `omap_mpuio_alloc_gc': drivers/gpio/gpio-omap.c:1087: undefined reference to `irq_alloc_generic_chip' drivers/gpio/gpio-omap.c:1100: undefined reference to `irq_setup_generic_chip' drivers/built-in.o: In function `omap_gpio_show_rev': drivers/gpio/gpio-omap.c:998: undefined reference to `irq_gc_mask_clr_bit' drivers/gpio/gpio-omap.c:998: undefined reference to `irq_gc_mask_set_bit' make: *** [vmlinux] Error 1 Signed-off-by: Axel Lin <axel.lin@gmail.com> --- arch/arm/plat-omap/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)