diff mbox

KEYS: x86_64 needs to use compat_sys_keyctl for 32-bit userspace

Message ID 146961615805.14395.5581949237156769439.stgit@warthog.procyon.org.uk (mailing list archive)
State New, archived
Headers show

Commit Message

David Howells July 27, 2016, 10:42 a.m. UTC
x86_64 needs to use compat_sys_keyctl for 32-bit userspace rather than
calling sys_keyctl.  The latter will work in a lot of cases, thereby hiding
the issue.

Reported-by: Stephan Mueller <smueller@chronox.de>
Signed-off-by: David Howells <dhowells@redhat.com>
cc: stable@vger.kernel.org
---

 arch/x86/entry/syscalls/syscall_32.tbl |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Stephan Mueller July 27, 2016, 11:21 a.m. UTC | #1
Am Mittwoch, 27. Juli 2016, 11:42:38 CEST schrieb David Howells:

Hi David,

> x86_64 needs to use compat_sys_keyctl for 32-bit userspace rather than
> calling sys_keyctl.  The latter will work in a lot of cases, thereby hiding
> the issue.
> 
> Reported-by: Stephan Mueller <smueller@chronox.de>
> Signed-off-by: David Howells <dhowells@redhat.com>

Tested-by: Stephan Mueller <smueller@chronox.de>

> cc: stable@vger.kernel.org
> ---
> 
>  arch/x86/entry/syscalls/syscall_32.tbl |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/entry/syscalls/syscall_32.tbl
> b/arch/x86/entry/syscalls/syscall_32.tbl index 4cddd17153fb..f848572169ea
> 100644
> --- a/arch/x86/entry/syscalls/syscall_32.tbl
> +++ b/arch/x86/entry/syscalls/syscall_32.tbl
> @@ -294,7 +294,7 @@
>  # 285 sys_setaltroot
>  286	i386	add_key			sys_add_key
>  287	i386	request_key		sys_request_key
> -288	i386	keyctl			sys_keyctl
> +288	i386	keyctl			sys_keyctl			compat_sys_keyctl
>  289	i386	ioprio_set		sys_ioprio_set
>  290	i386	ioprio_get		sys_ioprio_get
>  291	i386	inotify_init		sys_inotify_init



Ciao
Stephan
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/x86/entry/syscalls/syscall_32.tbl b/arch/x86/entry/syscalls/syscall_32.tbl
index 4cddd17153fb..f848572169ea 100644
--- a/arch/x86/entry/syscalls/syscall_32.tbl
+++ b/arch/x86/entry/syscalls/syscall_32.tbl
@@ -294,7 +294,7 @@ 
 # 285 sys_setaltroot
 286	i386	add_key			sys_add_key
 287	i386	request_key		sys_request_key
-288	i386	keyctl			sys_keyctl
+288	i386	keyctl			sys_keyctl			compat_sys_keyctl
 289	i386	ioprio_set		sys_ioprio_set
 290	i386	ioprio_get		sys_ioprio_get
 291	i386	inotify_init		sys_inotify_init