| Message ID | 20160801061838.GA17805@amitoj-Inspiron-3542 (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Mon, Aug 01, 2016 at 11:48:38AM +0530, Amitoj Kaur Chawla wrote: > of_platform_device_create returns NULL on error so an IS_ERR test is > incorrect here and a NULL check is required. > > The Coccinelle semantic patch used to make this change is as follows: > @@ > expression e; > @@ > > e = of_platform_device_create(...); > if( > - IS_ERR(e) > + !e > ) > { > <+... > return > - PTR_ERR(e) > + -ENODEV > ; > ...+> > } > > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> > --- > drivers/iommu/exynos-iommu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch didn't apply cleanly against v4.8-rc1, but I fixed it up and it is now in my tree, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index 97c41b8..2888bbf 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c @@ -1242,8 +1242,8 @@ static int __init exynos_iommu_of_setup(struct device_node *np) exynos_iommu_init(); pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root); - if (IS_ERR(pdev)) - return PTR_ERR(pdev); + if (!pdev) + return -ENODEV; of_iommu_set_ops(np, &exynos_iommu_ops); return 0;
of_platform_device_create returns NULL on error so an IS_ERR test is incorrect here and a NULL check is required. The Coccinelle semantic patch used to make this change is as follows: @@ expression e; @@ e = of_platform_device_create(...); if( - IS_ERR(e) + !e ) { <+... return - PTR_ERR(e) + -ENODEV ; ...+> } Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> --- drivers/iommu/exynos-iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)