[0096/1285] Replace numeric parameter like 0444 with macro
diff mbox

Message ID 20160802104021.20157-1-baolex.ni@intel.com
State New, archived
Headers show

Commit Message

baolex.ni Aug. 2, 2016, 10:40 a.m. UTC
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/block/xen-blkback/blkback.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Roger Pau Monné Aug. 2, 2016, 1:09 p.m. UTC | #1
On Tue, Aug 02, 2016 at 06:40:21PM +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
> 
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Patch
diff mbox

diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c
index 4809c15..73251ce 100644
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -63,7 +63,7 @@ 
  */
 
 static int xen_blkif_max_buffer_pages = 1024;
-module_param_named(max_buffer_pages, xen_blkif_max_buffer_pages, int, 0644);
+module_param_named(max_buffer_pages, xen_blkif_max_buffer_pages, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(max_buffer_pages,
 "Maximum number of free pages to keep in each block backend buffer");
 
@@ -79,7 +79,7 @@  MODULE_PARM_DESC(max_buffer_pages,
  */
 
 static int xen_blkif_max_pgrants = 1056;
-module_param_named(max_persistent_grants, xen_blkif_max_pgrants, int, 0644);
+module_param_named(max_persistent_grants, xen_blkif_max_pgrants, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(max_persistent_grants,
                  "Maximum number of grants to map persistently");
 
@@ -88,7 +88,7 @@  MODULE_PARM_DESC(max_persistent_grants,
  * are CPUs if user has not specified a value.
  */
 unsigned int xenblk_max_queues;
-module_param_named(max_queues, xenblk_max_queues, uint, 0644);
+module_param_named(max_queues, xenblk_max_queues, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(max_queues,
 		 "Maximum number of hardware queues per virtual disk." \
 		 "By default it is the number of online CPUs.");
@@ -116,7 +116,7 @@  MODULE_PARM_DESC(max_ring_page_order, "Maximum order of pages to be used for the
 
 /* Run-time switchable: /sys/module/blkback/parameters/ */
 static unsigned int log_stats;
-module_param(log_stats, int, 0644);
+module_param(log_stats, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 
 #define BLKBACK_INVALID_HANDLE (~0)