diff mbox

[0280/1285] Replace numeric parameter like 0444 with macro

Message ID 20160802105612.32479-1-baolex.ni@intel.com (mailing list archive)
State Rejected
Headers show

Commit Message

baolex.ni Aug. 2, 2016, 10:56 a.m. UTC 
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/input/mouse/appletouch.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox

Patch

diff --git a/drivers/input/mouse/appletouch.c b/drivers/input/mouse/appletouch.c
index ef234c9..149fa74 100644
--- a/drivers/input/mouse/appletouch.c
+++ b/drivers/input/mouse/appletouch.c
@@ -257,13 +257,13 @@  MODULE_LICENSE("GPL");
  * Make the threshold a module parameter
  */
 static int threshold = ATP_THRESHOLD;
-module_param(threshold, int, 0644);
+module_param(threshold, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(threshold, "Discard any change in data from a sensor"
 			    " (the trackpad has many of these sensors)"
 			    " less than this value.");
 
 static int debug;
-module_param(debug, int, 0644);
+module_param(debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(debug, "Activate debugging output");
 
 /*