[0295/1285] Replace numeric parameter like 0444 with macro
diff mbox

Message ID 20160802105743.1054-1-baolex.ni@intel.com
State Rejected
Headers show

Commit Message

baolex.ni Aug. 2, 2016, 10:57 a.m. UTC
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/input/touchscreen/usbtouchscreen.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch
diff mbox

diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c
index 2c41107..08216fd 100644
--- a/drivers/input/touchscreen/usbtouchscreen.c
+++ b/drivers/input/touchscreen/usbtouchscreen.c
@@ -61,11 +61,11 @@ 
 #define DRIVER_DESC		"USB Touchscreen Driver"
 
 static bool swap_xy;
-module_param(swap_xy, bool, 0644);
+module_param(swap_xy, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(swap_xy, "If set X and Y axes are swapped.");
 
 static bool hwcalib_xy;
-module_param(hwcalib_xy, bool, 0644);
+module_param(hwcalib_xy, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(hwcalib_xy, "If set hw-calibrated X/Y are used if available");
 
 /* device specifc data/functions */