pwm: pwm-tipwmss: Remove all pm_runtime gets and puts from the driver
diff mbox

Message ID 20160808100915.30149-1-vigneshr@ti.com
State New
Headers show

Commit Message

Vignesh Raghavendra Aug. 8, 2016, 10:09 a.m. UTC
From: Jyri Sarha <jsarha@ti.com>

Remove all pm_runtime gets and puts, and dummy pm_ops, from the
pwm-tipwmss driver as there is no direct hardware access. The runtime PM
needs to be enabled, so that the runtime PM framework takes care of
enabling/disabling of PWMSS clock when submodules of PWMSS (ECAP or
EHRPWM) call pm_runtime APIs. With this change PWMSS clock goes to
idle when none of the submodules are in use.

Signed-off-by: Jyri Sarha <jsarha@ti.com>
Signed-off-by: Vignesh R <vigneshr@ti.com>
---
 drivers/pwm/pwm-tipwmss.c | 19 -------------------
 1 file changed, 19 deletions(-)

Comments

Vignesh Raghavendra Aug. 30, 2016, 4:48 a.m. UTC | #1
On Monday 08 August 2016 03:39 PM, Vignesh R wrote:
> From: Jyri Sarha <jsarha@ti.com>
> 
> Remove all pm_runtime gets and puts, and dummy pm_ops, from the
> pwm-tipwmss driver as there is no direct hardware access. The runtime PM
> needs to be enabled, so that the runtime PM framework takes care of
> enabling/disabling of PWMSS clock when submodules of PWMSS (ECAP or
> EHRPWM) call pm_runtime APIs. With this change PWMSS clock goes to
> idle when none of the submodules are in use.
> 
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---


Gentle ping....

>  drivers/pwm/pwm-tipwmss.c | 19 -------------------
>  1 file changed, 19 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-tipwmss.c b/drivers/pwm/pwm-tipwmss.c
> index 829f4991c96f..7fa85a1604da 100644
> --- a/drivers/pwm/pwm-tipwmss.c
> +++ b/drivers/pwm/pwm-tipwmss.c
> @@ -34,7 +34,6 @@ static int pwmss_probe(struct platform_device *pdev)
>  	struct device_node *node = pdev->dev.of_node;
>  
>  	pm_runtime_enable(&pdev->dev);
> -	pm_runtime_get_sync(&pdev->dev);
>  
>  	/* Populate all the child nodes here... */
>  	ret = of_platform_populate(node, NULL, NULL, &pdev->dev);
> @@ -46,31 +45,13 @@ static int pwmss_probe(struct platform_device *pdev)
>  
>  static int pwmss_remove(struct platform_device *pdev)
>  {
> -	pm_runtime_put_sync(&pdev->dev);
>  	pm_runtime_disable(&pdev->dev);
>  	return 0;
>  }
>  
> -#ifdef CONFIG_PM_SLEEP
> -static int pwmss_suspend(struct device *dev)
> -{
> -	pm_runtime_put_sync(dev);
> -	return 0;
> -}
> -
> -static int pwmss_resume(struct device *dev)
> -{
> -	pm_runtime_get_sync(dev);
> -	return 0;
> -}
> -#endif
> -
> -static SIMPLE_DEV_PM_OPS(pwmss_pm_ops, pwmss_suspend, pwmss_resume);
> -
>  static struct platform_driver pwmss_driver = {
>  	.driver	= {
>  		.name	= "pwmss",
> -		.pm	= &pwmss_pm_ops,
>  		.of_match_table	= pwmss_of_match,
>  	},
>  	.probe	= pwmss_probe,
>
Thierry Reding Sept. 5, 2016, 6:51 a.m. UTC | #2
On Mon, Aug 08, 2016 at 03:39:15PM +0530, Vignesh R wrote:
> From: Jyri Sarha <jsarha@ti.com>
> 
> Remove all pm_runtime gets and puts, and dummy pm_ops, from the
> pwm-tipwmss driver as there is no direct hardware access. The runtime PM
> needs to be enabled, so that the runtime PM framework takes care of
> enabling/disabling of PWMSS clock when submodules of PWMSS (ECAP or
> EHRPWM) call pm_runtime APIs. With this change PWMSS clock goes to
> idle when none of the submodules are in use.
> 
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
>  drivers/pwm/pwm-tipwmss.c | 19 -------------------
>  1 file changed, 19 deletions(-)

Applied, with a slightly modified commit message.

Thanks,
Thierry
Vignesh Raghavendra Sept. 5, 2016, 1:43 p.m. UTC | #3
On 9/5/2016 12:21 PM, Thierry Reding wrote:
> On Mon, Aug 08, 2016 at 03:39:15PM +0530, Vignesh R wrote:
>> From: Jyri Sarha <jsarha@ti.com>
>>
>> Remove all pm_runtime gets and puts, and dummy pm_ops, from the
>> pwm-tipwmss driver as there is no direct hardware access. The runtime PM
>> needs to be enabled, so that the runtime PM framework takes care of
>> enabling/disabling of PWMSS clock when submodules of PWMSS (ECAP or
>> EHRPWM) call pm_runtime APIs. With this change PWMSS clock goes to
>> idle when none of the submodules are in use.
>>
>> Signed-off-by: Jyri Sarha <jsarha@ti.com>
>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>> ---
>>  drivers/pwm/pwm-tipwmss.c | 19 -------------------
>>  1 file changed, 19 deletions(-)
> 
> Applied, with a slightly modified commit message.
> 

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/pwm/pwm-tipwmss.c b/drivers/pwm/pwm-tipwmss.c
index 829f4991c96f..7fa85a1604da 100644
--- a/drivers/pwm/pwm-tipwmss.c
+++ b/drivers/pwm/pwm-tipwmss.c
@@ -34,7 +34,6 @@  static int pwmss_probe(struct platform_device *pdev)
 	struct device_node *node = pdev->dev.of_node;
 
 	pm_runtime_enable(&pdev->dev);
-	pm_runtime_get_sync(&pdev->dev);
 
 	/* Populate all the child nodes here... */
 	ret = of_platform_populate(node, NULL, NULL, &pdev->dev);
@@ -46,31 +45,13 @@  static int pwmss_probe(struct platform_device *pdev)
 
 static int pwmss_remove(struct platform_device *pdev)
 {
-	pm_runtime_put_sync(&pdev->dev);
 	pm_runtime_disable(&pdev->dev);
 	return 0;
 }
 
-#ifdef CONFIG_PM_SLEEP
-static int pwmss_suspend(struct device *dev)
-{
-	pm_runtime_put_sync(dev);
-	return 0;
-}
-
-static int pwmss_resume(struct device *dev)
-{
-	pm_runtime_get_sync(dev);
-	return 0;
-}
-#endif
-
-static SIMPLE_DEV_PM_OPS(pwmss_pm_ops, pwmss_suspend, pwmss_resume);
-
 static struct platform_driver pwmss_driver = {
 	.driver	= {
 		.name	= "pwmss",
-		.pm	= &pwmss_pm_ops,
 		.of_match_table	= pwmss_of_match,
 	},
 	.probe	= pwmss_probe,