| Message ID | 1470739896-11088-2-git-send-email-tomeu.vizoso@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Aug 09, 2016 at 12:51:32PM +0200, Tomeu Vizoso wrote: > This backpointer allows DP helpers to access the connector it's being > used for. > > Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> > --- > > include/drm/drm_dp_helper.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h > index 63b8bd502444..f66cc8501d71 100644 > --- a/include/drm/drm_dp_helper.h > +++ b/include/drm/drm_dp_helper.h > @@ -710,6 +710,7 @@ struct drm_dp_aux_msg { > * @name: user-visible name of this AUX channel and the I2C-over-AUX adapter > * @ddc: I2C adapter that can be used for I2C-over-AUX communication > * @dev: pointer to struct device that is the parent for this AUX channel > + * @connector: backpointer to connector that uses this AUX channel > * @hw_mutex: internal mutex used for locking transfers > * @transfer: transfers a message representing a single AUX transaction > * > @@ -746,6 +747,7 @@ struct drm_dp_aux { > const char *name; > struct i2c_adapter ddc; > struct device *dev; Ah, drm_dp_aux_dev.c uses the dev here, not the connector directly. I think having both is too much, and we instead should replace dev by the newly added connector for consistency in how to get at both the parent device and the connector (which really is the same thing, almost). -Daniel > + struct drm_connector *connector; > struct mutex hw_mutex; > ssize_t (*transfer)(struct drm_dp_aux *aux, > struct drm_dp_aux_msg *msg); > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 63b8bd502444..f66cc8501d71 100644 --- a/include/drm/drm_dp_helper.h +++ b/include/drm/drm_dp_helper.h @@ -710,6 +710,7 @@ struct drm_dp_aux_msg { * @name: user-visible name of this AUX channel and the I2C-over-AUX adapter * @ddc: I2C adapter that can be used for I2C-over-AUX communication * @dev: pointer to struct device that is the parent for this AUX channel + * @connector: backpointer to connector that uses this AUX channel * @hw_mutex: internal mutex used for locking transfers * @transfer: transfers a message representing a single AUX transaction * @@ -746,6 +747,7 @@ struct drm_dp_aux { const char *name; struct i2c_adapter ddc; struct device *dev; + struct drm_connector *connector; struct mutex hw_mutex; ssize_t (*transfer)(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg);
This backpointer allows DP helpers to access the connector it's being used for. Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> --- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+)