[PATCHv2,xfsprogs,03/14] remove unecessary definitions of _FILE_OFFSET_BITS

Commit Message

Felix Janda Aug. 7, 2016, 5:28 a.m. UTC

now that we use AC_SYS_LARGEFILE, there is no need to explicitly
define _FILE_OFFSET_BITS.

Signed-off-by: Felix Janda <[e-mail]>
---
 include/builddefs.in  | 2 +-
 m4/package_libcdev.m4 | 9 ---------
 2 files changed, 1 insertion(+), 10 deletions(-)

Comments

Christoph Hellwig Aug. 18, 2016, 5:38 p.m. UTC | #1

On Sun, Aug 07, 2016 at 07:28:16AM +0200, Felix Janda wrote:
> now that we use AC_SYS_LARGEFILE, there is no need to explicitly
> define _FILE_OFFSET_BITS.

Looks good,

Reviewed-by: Christoph Hellwig <[e-mail]>

Patch

diff --git a/include/builddefs.in b/include/builddefs.in
index 7153d7a..d406615 100644
--- a/include/builddefs.in
+++ b/include/builddefs.in
@@ -114,7 +114,7 @@  GCCFLAGS = -funsigned-char -fno-strict-aliasing -Wall
 #	   -Wbitwise -Wno-transparent-union -Wno-old-initializer -Wno-decl
 
 ifeq ($(PKG_PLATFORM),linux)
-PCFLAGS = -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 $(GCCFLAGS)
+PCFLAGS = -D_GNU_SOURCE $(GCCFLAGS)
 ifeq ($(HAVE_UMODE_T),yes)
 PCFLAGS += -DHAVE_UMODE_T
 endif
diff --git a/m4/package_libcdev.m4 b/m4/package_libcdev.m4
index 6c94475..0999c8b 100644
--- a/m4/package_libcdev.m4
+++ b/m4/package_libcdev.m4
@@ -5,7 +5,6 @@  AC_DEFUN([AC_HAVE_FADVISE],
   [ AC_MSG_CHECKING([for fadvise ])
     AC_TRY_COMPILE([
 #define _GNU_SOURCE
-#define _FILE_OFFSET_BITS 64
 #include <fcntl.h>
     ], [
 	posix_fadvise(0, 1, 0, POSIX_FADV_NORMAL);
@@ -22,7 +21,6 @@  AC_DEFUN([AC_HAVE_MADVISE],
   [ AC_MSG_CHECKING([for madvise ])
     AC_TRY_COMPILE([
 #define _GNU_SOURCE
-#define _FILE_OFFSET_BITS 64
 #include <sys/mman.h>
     ], [
 	posix_madvise(0, 0, MADV_NORMAL);
@@ -39,7 +37,6 @@  AC_DEFUN([AC_HAVE_MINCORE],
   [ AC_MSG_CHECKING([for mincore ])
     AC_TRY_COMPILE([
 #define _GNU_SOURCE
-#define _FILE_OFFSET_BITS 64
 #include <sys/mman.h>
     ], [
 	mincore(0, 0, 0);
@@ -56,7 +53,6 @@  AC_DEFUN([AC_HAVE_SENDFILE],
   [ AC_MSG_CHECKING([for sendfile ])
     AC_TRY_COMPILE([
 #define _GNU_SOURCE
-#define _FILE_OFFSET_BITS 64
 #include <sys/sendfile.h>
     ], [
          sendfile(0, 0, 0, 0);
@@ -106,7 +102,6 @@  AC_DEFUN([AC_HAVE_FALLOCATE],
   [ AC_MSG_CHECKING([for fallocate])
     AC_TRY_LINK([
 #define _GNU_SOURCE
-#define _FILE_OFFSET_BITS 64
 #include <fcntl.h>
 #include <linux/falloc.h>
     ], [
@@ -124,7 +119,6 @@  AC_DEFUN([AC_HAVE_FIEMAP],
   [ AC_MSG_CHECKING([for fiemap])
     AC_TRY_LINK([
 #define _GNU_SOURCE
-#define _FILE_OFFSET_BITS 64
 #include <linux/fs.h>
 #include <linux/fiemap.h>
     ], [
@@ -142,7 +136,6 @@  AC_DEFUN([AC_HAVE_FIEMAP],
 AC_DEFUN([AC_HAVE_PREADV],
   [ AC_MSG_CHECKING([for preadv])
     AC_TRY_LINK([
-#define _FILE_OFFSET_BITS 64
 #define _BSD_SOURCE
 #include <sys/uio.h>
     ], [
@@ -177,7 +170,6 @@  AC_DEFUN([AC_HAVE_SYNC_FILE_RANGE],
   [ AC_MSG_CHECKING([for sync_file_range])
     AC_TRY_LINK([
 #define _GNU_SOURCE
-#define _FILE_OFFSET_BITS 64
 #include <fcntl.h>
     ], [
          sync_file_range(0, 0, 0, 0);
@@ -194,7 +186,6 @@  AC_DEFUN([AC_HAVE_SYNCFS],
   [ AC_MSG_CHECKING([for syncfs])
     AC_TRY_LINK([
 #define _GNU_SOURCE
-#define _FILE_OFFSET_BITS 64
 #include <unistd.h>
     ], [
          syncfs(0);