| Message ID | 1471646606-28519-2-git-send-email-daniel.kiper@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
>>> On 20.08.16 at 00:43, <daniel.kiper@oracle.com> wrote: > ..nor EFI platforms with runtime services enabled. > > Suggested-by: Jan Beulich <jbeulich@suse.com> > Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com> > --- > v5 - suggestions/fixes: > - fix build error > (suggested by Jan Beulich), > - improve commit message. Not really - it is now stale, as there's no checking of whether runtime service use is allowed. I also don't see what change in behavior this patch brings when viewed on its own. I think instead of fixing the prior build error you'd better have moved this later in the series. Jan
diff --git a/xen/arch/x86/shutdown.c b/xen/arch/x86/shutdown.c index 0e1499d..972e20b 100644 --- a/xen/arch/x86/shutdown.c +++ b/xen/arch/x86/shutdown.c @@ -80,6 +80,9 @@ static void __init set_reboot_type(char *str) break; str++; } + + if ( reboot_type == BOOT_EFI && !efi_enabled ) + reboot_type = BOOT_INVALID; } custom_param("reboot", set_reboot_type);
..nor EFI platforms with runtime services enabled. Suggested-by: Jan Beulich <jbeulich@suse.com> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com> --- v5 - suggestions/fixes: - fix build error (suggested by Jan Beulich), - improve commit message. --- xen/arch/x86/shutdown.c | 3 +++ 1 file changed, 3 insertions(+)