diff mbox

drm/i915: Suppress DRM_ERROR for D_COMP write on Haswell

Message ID 20160824101607.13671-1-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Chris Wilson Aug. 24, 2016, 10:16 a.m. UTC
The D_COMP (render decompression) register write is followed by a status
check and another error (either that the decompression shutdown or the
lpll is enabled). Since we are followed by another, more pertinent,
error we can reduce the pcode timeout to a debug and squelch a sporadic
error message during suspend.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97465
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/intel_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Matthew Auld Aug. 24, 2016, 11:25 a.m. UTC | #1
On 24 August 2016 at 11:16, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> The D_COMP (render decompression) register write is followed by a status
> check and another error (either that the decompression shutdown or the
> lpll is enabled). Since we are followed by another, more pertinent,
> error we can reduce the pcode timeout to a debug and squelch a sporadic
> error message during suspend.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97465
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index b3ea141c0ce8..eb4c989e98a3 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -9973,7 +9973,7 @@  static void hsw_write_dcomp(struct drm_i915_private *dev_priv, uint32_t val)
 		mutex_lock(&dev_priv->rps.hw_lock);
 		if (sandybridge_pcode_write(dev_priv, GEN6_PCODE_WRITE_D_COMP,
 					    val))
-			DRM_ERROR("Failed to write to D_COMP\n");
+			DRM_DEBUG_KMS("Failed to write to D_COMP\n");
 		mutex_unlock(&dev_priv->rps.hw_lock);
 	} else {
 		I915_WRITE(D_COMP_BDW, val);