diff mbox

[media] ad5820: fix one smatch warning

Message ID 1ee6dd5a918bd98dea20a2847f1ca15964dca952.1472037792.git.mchehab@s-opensource.com (mailing list archive)
State New, archived
Headers show

Commit Message

Mauro Carvalho Chehab Aug. 24, 2016, 11:23 a.m. UTC 
drivers/media/i2c/ad5820.c:61:24: error: dubious one-bit signed bitfield

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---
 drivers/media/i2c/ad5820.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sakari Ailus Aug. 24, 2016, 11:46 a.m. UTC | #1 
Hi Mauro,

Mauro Carvalho Chehab wrote:
> drivers/media/i2c/ad5820.c:61:24: error: dubious one-bit signed bitfield
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
> ---
>  drivers/media/i2c/ad5820.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c
> index 62cc1f54622f..d7ad5c1a1219 100644
> --- a/drivers/media/i2c/ad5820.c
> +++ b/drivers/media/i2c/ad5820.c
> @@ -58,7 +58,7 @@ struct ad5820_device {
>  	struct mutex power_lock;
>  	int power_count;
>  
> -	int standby : 1;
> +	unsigned int standby : 1;

I guess a bool would be a better match for this one. It's what it's used
for. [01] assignments should be replaced by boolean values.

I can submit a patch for this as well, up to you.

>  };
>  
>  static int ad5820_write(struct ad5820_device *coil, u16 data)
>
diff mbox

Patch

diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c
index 62cc1f54622f..d7ad5c1a1219 100644
--- a/drivers/media/i2c/ad5820.c
+++ b/drivers/media/i2c/ad5820.c
@@ -58,7 +58,7 @@  struct ad5820_device {
 	struct mutex power_lock;
 	int power_count;
 
-	int standby : 1;
+	unsigned int standby : 1;
 };
 
 static int ad5820_write(struct ad5820_device *coil, u16 data)