| Message ID | 20160826152546.604384-3-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Aug 26, 2016 at 5:25 PM, Arnd Bergmann <arnd@arndb.de> wrote: [I don't see why Torvalds was CC'ed on this patch? Was there some specific complaint from his side that I screw things up or just the wrong Linus?] > The addition of the Nomadik support in this driver introduced > a bug in clcdfb_of_init_display(), which now calls init_panel > with an uninitialized 'endpoint' pointer, as "gcc -Wmaybe-uninitialized" > warns: > > drivers/video/fbdev/amba-clcd.c: In function 'clcdfb_of_init_display': > drivers/video/fbdev/amba-clcd.c:785:5: error: 'endpoint' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > This reverts the broken part of the function to what it was before > the patch, which is the best guess I have to what it should be. > I assume this was left over from an attempted rework of the > code that was partially backed out. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Fixes: 046ad6cdeb3f ("video: ARM CLCD: support Nomadik variant") > Cc: Linus Walleij <linus.walleij@linaro.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Tomi: I think this bug was also reported by Ian King, so suggest adding his Reported-by: Colin Ian King <colin.king@canonical.com> When applying. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Monday 29 August 2016, Linus Walleij wrote: > On Fri, Aug 26, 2016 at 5:25 PM, Arnd Bergmann <arnd@arndb.de> wrote: > > [I don't see why Torvalds was CC'ed on this patch? Was there > some specific complaint from his side that I screw things up > or just the wrong Linus?] It was intentional: as mentioned in the introductory mail, he did the patch that prevented you from seeing the five warnings that I got after reverting 6e8d666e9253. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 29/08/16 16:18, Linus Walleij wrote: > On Fri, Aug 26, 2016 at 5:25 PM, Arnd Bergmann <arnd@arndb.de> wrote: > > [I don't see why Torvalds was CC'ed on this patch? Was there > some specific complaint from his side that I screw things up > or just the wrong Linus?] > >> The addition of the Nomadik support in this driver introduced >> a bug in clcdfb_of_init_display(), which now calls init_panel >> with an uninitialized 'endpoint' pointer, as "gcc -Wmaybe-uninitialized" >> warns: >> >> drivers/video/fbdev/amba-clcd.c: In function 'clcdfb_of_init_display': >> drivers/video/fbdev/amba-clcd.c:785:5: error: 'endpoint' may be used uninitialized in this function [-Werror=maybe-uninitialized] >> >> This reverts the broken part of the function to what it was before >> the patch, which is the best guess I have to what it should be. >> I assume this was left over from an attempted rework of the >> code that was partially backed out. >> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> Fixes: 046ad6cdeb3f ("video: ARM CLCD: support Nomadik variant") >> Cc: Linus Walleij <linus.walleij@linaro.org> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > Tomi: I think this bug was also reported by Ian King, so suggest > adding his > Reported-by: Colin Ian King <colin.king@canonical.com> > Thanks, queued for v4.9. Tomi
diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c index c342ff370108..ec2671d98abc 100644 --- a/drivers/video/fbdev/amba-clcd.c +++ b/drivers/video/fbdev/amba-clcd.c @@ -782,12 +782,9 @@ static int clcdfb_of_init_display(struct clcd_fb *fb) /* * Fetch the panel endpoint. */ - if (!endpoint) { - endpoint = of_graph_get_next_endpoint(fb->dev->dev.of_node, - NULL); - if (!endpoint) - return -ENODEV; - } + endpoint = of_graph_get_next_endpoint(fb->dev->dev.of_node, NULL); + if (!endpoint) + return -ENODEV; if (fb->vendor->init_panel) { err = fb->vendor->init_panel(fb, endpoint);
The addition of the Nomadik support in this driver introduced a bug in clcdfb_of_init_display(), which now calls init_panel with an uninitialized 'endpoint' pointer, as "gcc -Wmaybe-uninitialized" warns: drivers/video/fbdev/amba-clcd.c: In function 'clcdfb_of_init_display': drivers/video/fbdev/amba-clcd.c:785:5: error: 'endpoint' may be used uninitialized in this function [-Werror=maybe-uninitialized] This reverts the broken part of the function to what it was before the patch, which is the best guess I have to what it should be. I assume this was left over from an attempted rework of the code that was partially backed out. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes: 046ad6cdeb3f ("video: ARM CLCD: support Nomadik variant") Cc: Linus Walleij <linus.walleij@linaro.org> --- Cc: linux-fbdev@vger.kernel.org Cc: Russell King <linux@armlinux.org.uk> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> drivers/video/fbdev/amba-clcd.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)