From patchwork Sun Aug 28 16:00:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xavier Drudis Ferran X-Patchwork-Id: 9304889 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 569EB601C0 for ; Tue, 30 Aug 2016 05:55:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 467CD28A3B for ; Tue, 30 Aug 2016 05:55:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 396EE28AC2; Tue, 30 Aug 2016 05:55:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AAE8E28A3B for ; Tue, 30 Aug 2016 05:55:43 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id E73E8266A0D; Tue, 30 Aug 2016 07:55:42 +0200 (CEST) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id D5FE2266A0A; Tue, 30 Aug 2016 07:44:59 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id E79D5266938; Mon, 29 Aug 2016 20:53:17 +0200 (CEST) Received: from mx2.tinet.org (mx2.tinet.org [195.77.216.147]) by alsa0.perex.cz (Postfix) with ESMTP id 27FB0266A69 for ; Mon, 29 Aug 2016 19:58:33 +0200 (CEST) X-ASG-Debug-ID: 1472400056-069e0e633856800001-UKjUFf Received: from smtp01.tinet.org (smtp01.tinet.org [195.77.216.131]) by mx2.tinet.org with ESMTP id ESUfLVImCAKF6RxH for ; Sun, 28 Aug 2016 18:00:56 +0200 (CEST) X-Barracuda-Envelope-From: xdrudis@tinet.cat X-Barracuda-Effective-Source-IP: smtp01.tinet.org[195.77.216.131] X-Barracuda-Apparent-Source-IP: 195.77.216.131 Received: (qmail 11792 invoked from network); 28 Aug 2016 16:00:56 -0000 Received: from 4.red-81-38-76.dynamicip.rima-tde.net (HELO begut) (xdrudis@[81.38.76.4]) (envelope-sender ) by smtp01.tinet.org (qmail-ldap-1.03) with SMTP for ; 28 Aug 2016 16:00:56 -0000 Received: from xdrudis by begut with local (Exim 4.84_2) (envelope-from ) id 1be2Vz-0000cO-AY; Sun, 28 Aug 2016 18:00:55 +0200 Date: Sun, 28 Aug 2016 18:00:55 +0200 From: Xavi Drudis Ferran To: Timur Tabi , Nicolin Chen , Xiubo Li , Shengjiu Wang Message-ID: <20160828160055.GA2122@begut> X-ASG-Orig-Subj: Setting some clocks back to DUMMY fixes spdif output on imx6q wandboard rev B1 MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-Barracuda-Connect: smtp01.tinet.org[195.77.216.131] X-Barracuda-Start-Time: 1472400056 X-Barracuda-URL: https://webmail.tinet.cat:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 1724 X-Virus-Scanned: by bsmtpd at tinet.org X-Barracuda-BRTS-Status: 1 X-Barracuda-Bayes: INNOCENT GLOBAL 0.4998 1.0000 0.0000 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=6.0 KILL_LEVEL=8.0 tests=BSF_SC0_MISMATCH_TO X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.32396 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 BSF_SC0_MISMATCH_TO Envelope rcpt doesn't match header X-Mailman-Approved-At: Tue, 30 Aug 2016 07:44:42 +0200 Cc: alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org Subject: [alsa-devel] Setting some clocks back to DUMMY fixes spdif output on imx6q wandboard rev B1 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Hello. Sorry for my unfamiliarity with the kernel community. I'm afraid I'll be getting the procedure wrong... I was using linux-libre-3.19 (implies no working sdma) with a wandboard quad (Freescale imx6q). Spidf output worked fine. When I upgraded to linux-libre-4.7 spdif output was supressed without any error (precisely, with the same errors about sdma that 3.19 gave). I saw someone else reporting the same elsewhere with linux-4.4 https://forum.digikey.com/thread/34240 (but I don't have a login there) This patch fixes it for me and sound works again on spdif. But I don't know if it can break (or fix?) something for some other boards or kernels or cases... I hardly know what I'm doing. The commits that might have caused the problem for me might be commit 833f2cbf7091099baee28136dc68678e974c0ac5 Author: Shengjiu Wang Date: Sat Oct 10 18:15:07 2015 +0800 ARM: dts: imx6: change the core clock of spdif The correct core clock of spdif is SPDIF_GCLK, which is added to clock tree. So the dts also need to be updated. Signed-off-by: Shengjiu Wang Signed-off-by: Shawn Guo (the commit changed more clocks than SPDIF_GCLK) It might have to do with vendor commit http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/commit/arch/arm/boot/dts/imx6qdl.dtsi?h=imx_4.1.15_1.0.0_ga&id=dd7ebdf5bf0458e08f0be62fd49bc6f1ca9b2f25 The issue is fixed for me with this patch but I'm not sure what's the best way to help fix any issue someone else may have or what other info or test you might need. Any guidance welcome. Thank you for linux. --- linux-4.7-no-spdif-out/arch/arm/boot/dts/imx6qdl.dtsi 2016-07-25 00:19:43.000000000 +0200 +++ linux-4.7/arch/arm/boot/dts/imx6qdl.dtsi 2016-08-28 17:59:14.276774409 +0200 @@ -240,9 +240,9 @@ <&sdma 15 18 0>; dma-names = "rx", "tx"; clocks = <&clks IMX6QDL_CLK_SPDIF_GCLK>, <&clks IMX6QDL_CLK_OSC>, - <&clks IMX6QDL_CLK_SPDIF>, <&clks IMX6QDL_CLK_ASRC>, - <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_ESAI_EXTAL>, - <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_MLB>, + <&clks IMX6QDL_CLK_SPDIF>, <&clks IMX6QDL_CLK_DUMMY>, + <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_DUMMY>, + <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_SPBA>; clock-names = "core", "rxtx0", "rxtx1", "rxtx2",